jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360862 )
Change subject: Remove ConstraintParameterParser from SymmetricChecker
......................................................................
Remove ConstraintParameterParser from SymmetricChecker
The parser was no longer used.
Change-Id: I4a15196f28b616ae037f36e2fedc376c031e76e1
---
M includes/ConstraintCheck/Checker/SymmetricChecker.php
M includes/ConstraintReportFactory.php
M tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
3 files changed, 1 insertion(+), 19 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/ConstraintCheck/Checker/SymmetricChecker.php
b/includes/ConstraintCheck/Checker/SymmetricChecker.php
index 16ad9a0..8cfbc1a 100644
--- a/includes/ConstraintCheck/Checker/SymmetricChecker.php
+++ b/includes/ConstraintCheck/Checker/SymmetricChecker.php
@@ -9,7 +9,6 @@
use Wikibase\DataModel\Statement\StatementListProvider;
use WikibaseQuality\ConstraintReport\Constraint;
use WikibaseQuality\ConstraintReport\ConstraintCheck\ConstraintChecker;
-use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser;
use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConnectionCheckerHelper;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult;
use WikibaseQuality\ConstraintReport\ConstraintParameterRenderer;
@@ -28,11 +27,6 @@
private $entityLookup;
/**
- * @var ConstraintParameterParser
- */
- private $constraintParameterParser;
-
- /**
* @var ConnectionCheckerHelper
*/
private $connectionCheckerHelper;
@@ -44,18 +38,15 @@
/**
* @param EntityLookup $lookup
- * @param ConstraintParameterParser $helper
* @param ConnectionCheckerHelper $connectionCheckerHelper
* @param ConstraintParameterRenderer $constraintParameterRenderer
*/
public function __construct(
EntityLookup $lookup,
- ConstraintParameterParser $helper,
ConnectionCheckerHelper $connectionCheckerHelper,
ConstraintParameterRenderer $constraintParameterRenderer
) {
$this->entityLookup = $lookup;
- $this->constraintParameterParser = $helper;
$this->connectionCheckerHelper = $connectionCheckerHelper;
$this->constraintParameterRenderer =
$constraintParameterRenderer;
}
diff --git a/includes/ConstraintReportFactory.php
b/includes/ConstraintReportFactory.php
index 912ea51..3a2a699 100644
--- a/includes/ConstraintReportFactory.php
+++ b/includes/ConstraintReportFactory.php
@@ -200,7 +200,7 @@
'Item' => new ItemChecker( $this->lookup,
$this->constraintStatementParameterParser, $connectionCheckerHelper,
$this->constraintParameterRenderer ),
'Target required claim' => new
TargetRequiredClaimChecker(
$this->lookup,
$this->constraintStatementParameterParser, $connectionCheckerHelper,
$this->constraintParameterRenderer ),
- 'Symmetric' => new SymmetricChecker(
$this->lookup, $constraintParameterParser, $connectionCheckerHelper,
$this->constraintParameterRenderer ),
+ 'Symmetric' => new SymmetricChecker(
$this->lookup, $connectionCheckerHelper, $this->constraintParameterRenderer ),
'Inverse' => new InverseChecker( $this->lookup,
$this->constraintStatementParameterParser, $connectionCheckerHelper,
$this->constraintParameterRenderer ),
'Qualifier' => new QualifierChecker(),
'Qualifiers' => new QualifiersChecker(
$this->constraintStatementParameterParser, $this->constraintParameterRenderer ),
diff --git a/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
b/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
index 856885e..eb1c116 100644
--- a/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
+++ b/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
@@ -14,7 +14,6 @@
use WikibaseQuality\ConstraintReport\Constraint;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\SymmetricChecker;
use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConnectionCheckerHelper;
-use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser;
use WikibaseQuality\ConstraintReport\Tests\ConstraintParameters;
use WikibaseQuality\ConstraintReport\Tests\ResultAssertions;
use WikibaseQuality\Tests\Helper\JsonFileEntityLookup;
@@ -25,7 +24,6 @@
* @group WikibaseQualityConstraints
*
* @uses \WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult
- * @uses
\WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser
*
* @author BP2014N1
* @license GNU GPL v2+
@@ -40,11 +38,6 @@
private $lookup;
/**
- * @var ConstraintParameterParser
- */
- private $helper;
-
- /**
* @var ConnectionCheckerHelper
*/
private $connectionCheckerHelper;
@@ -57,11 +50,9 @@
protected function setUp() {
parent::setUp();
$this->lookup = new JsonFileEntityLookup( __DIR__ );
- $this->helper = new ConstraintParameterParser();
$this->connectionCheckerHelper = new ConnectionCheckerHelper();
$this->checker = new SymmetricChecker(
$this->lookup,
- $this->helper,
$this->connectionCheckerHelper,
$this->getConstraintParameterRenderer()
);
--
To view, visit https://gerrit.wikimedia.org/r/360862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a15196f28b616ae037f36e2fedc376c031e76e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
