jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360567 )
Change subject: Hygiene: More uploads cleanup
......................................................................
Hygiene: More uploads cleanup
it amazes me how a feature removed over 2 years ago still has
artifacts :)
The photo-loaded event is no longer needed and relates to adding
images post-upload to certain views.
The event is removed as is the one usage.
Change-Id: Ib724fd2ee7cd195e927cb463dd374d559b7e30a1
---
M resources/mobile.gallery/PhotoList.js
M resources/skins.minerva.scripts/init.js
2 files changed, 1 insertion(+), 24 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.gallery/PhotoList.js
b/resources/mobile.gallery/PhotoList.js
index 1e67282..5e7cdcc 100644
--- a/resources/mobile.gallery/PhotoList.js
+++ b/resources/mobile.gallery/PhotoList.js
@@ -82,33 +82,13 @@
this.$( '.empty' ).remove();
},
/**
- * Prepend a photo to the view.
- * @method
- * @param {Object} photoData Options describing a new
{PhotoItem}
- * FIXME: Code duplication with PhotoList::appendPhoto
- */
- prependPhoto: function ( photoData ) {
- var photoItem;
-
- photoData.width = this.gateway.getWidth();
- photoItem = new PhotoItem( photoData ).prependTo(
this.$list );
- this.hideEmptyMessage();
- M.emit( 'photo-loaded', photoItem.$el );
- },
- /**
* Append a photo to the view.
* @method
* @param {Object} photoData Options describing a new
{PhotoItem}
*/
appendPhoto: function ( photoData ) {
- var photoItem = new PhotoItem( photoData ).appendTo(
this.$list );
+ new PhotoItem( photoData ).appendTo( this.$list );
this.hideEmptyMessage();
- /**
- * @event photo-loaded
- * @param {jQuery.Object} element belonging to view
- * Fired when a new {PhotoItem} has been added to the
current view.
- */
- M.emit( 'photo-loaded', photoItem.$el );
},
/**
* Load photos into the view using {{PhotoListApi}} when the
end is near
diff --git a/resources/skins.minerva.scripts/init.js
b/resources/skins.minerva.scripts/init.js
index 83c7b3c..3d33fc6 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -115,9 +115,6 @@
return result;
} );
- // for Special:Uploads
- M.on( 'photo-loaded', initMediaViewer );
-
// Setup
$( function () {
initButton();
--
To view, visit https://gerrit.wikimedia.org/r/360567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib724fd2ee7cd195e927cb463dd374d559b7e30a1
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
