jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360166 )
Change subject: relatedArticles: SamplingRate -> BucketSize
......................................................................
relatedArticles: SamplingRate -> BucketSize
In order to avoid further confusion, clarify that we're bucketing users
for experiments.
Supporting changes:
* Ensure that the *SamplingRate variables are set to maintain backwards
compatibility with the currently deployed version of RelatedArticles.
Bug: T167236
Change-Id: I752cdf068ca25bffb38229380785e7da1a208049
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings-labs.php
M wmf-config/InitialiseSettings.php
3 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Thcipriani: Looks good to me, approved
jenkins-bot: Verified
Jdlrobson: Looks good to me, but someone else must approve
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 61f8902..d284d70 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2891,9 +2891,14 @@
if ( $wmgRelatedArticlesShowInFooter ) {
$wgRelatedArticlesShowInSidebar = false;
$wgRelatedArticlesShowInFooter = true;
- $wgRelatedArticlesLoggingSamplingRate = 0.01;
+ $wgRelatedArticlesLoggingBucketSize = 0.01;
$wgRelatedArticlesUseCirrusSearch =
$wmgRelatedArticlesUseCirrusSearch;
$wgRelatedArticlesOnlyUseCirrusSearch = false;
+
+ // T167236: Maintain backwards compatibility with the currently
deployed
+ // version of RelatedArticles.
+ $wgRelatedArticlesEnabledSamplingRate =
$wgRelatedArticlesEnabledBucketSize;
+ $wgRelatedArticlesLoggingSamplingRate =
$wgRelatedArticlesLoggingBucketSize;
}
}
diff --git a/wmf-config/InitialiseSettings-labs.php
b/wmf-config/InitialiseSettings-labs.php
index 2ff902b..1bc5f31 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -359,7 +359,7 @@
'wmgUseRelatedArticles' => [
'default' => true,
],
- 'wgRelatedArticlesEnabledSamplingRate' => [
+ 'wgRelatedArticlesEnabledBucketSize' => [
'default' => 1,
'enwiki' => 1,
],
diff --git a/wmf-config/InitialiseSettings.php
b/wmf-config/InitialiseSettings.php
index dba1f99..daa523b 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -17304,6 +17304,12 @@
'enwiki' => 0.98,
],
+'wgRelatedArticlesEnabledBucketSize' => [
+ 'default' => 1,
+ // T167310
+ 'enwiki' => 0.98,
+],
+
'wmgUseRelatedSites' => [
'default' => false,
'wikivoyage' => true,
--
To view, visit https://gerrit.wikimedia.org/r/360166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I752cdf068ca25bffb38229380785e7da1a208049
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: Thcipriani <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
