jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/360868 )

Change subject: Remove redundant title attribute
......................................................................


Remove redundant title attribute

The title is replaced by jQuery.i18n according to the data-i18n
attribute, so specifying it directly only causes confusion (especially
since the HTML text doesn’t match the i18n/en.json text).

Change-Id: Iecb57caaa50ef7152cfad0458db7950c78299da6
---
M index.html
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/index.html b/index.html
index bb222ff..53b9568 100644
--- a/index.html
+++ b/index.html
@@ -154,7 +154,7 @@
                                                                  </a>
                                                                  <ul 
class="dropdown-menu">
                                                                        <li><a 
href="#" class="shortUrlTrigger result" target="_blank"  
data-i18n="[title]wdqs-app-result-shorturl-title" data-toggle="popover"><span 
data-i18n="wdqs-app-result-shorturl"></span></a></li>
-                                                                       <li><a 
target="_blank" title="SPARQL endpoint REST request" class="queryUri" 
data-i18n="[title]wdqs-app-result-endpoint-title"><span 
data-i18n="wdqs-app-result-endpoint"></span></a></li>
+                                                                       <li><a 
target="_blank" class="queryUri" 
data-i18n="[title]wdqs-app-result-endpoint-title"><span 
data-i18n="wdqs-app-result-endpoint"></span></a></li>
                                                                        <li><a 
href="#" class="embed result" target="_blank" data-toggle="popover" 
data-i18n="wdqs-app-result-embed"></a></li>
                                                                  </ul>
                                                        </li>

-- 
To view, visit https://gerrit.wikimedia.org/r/360868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecb57caaa50ef7152cfad0458db7950c78299da6
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to