Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/360994 )

Change subject: proxyleaks:  Avoid some edge cases that caused occasional 
script failure
......................................................................

proxyleaks:  Avoid some edge cases that caused occasional script failure

Change-Id: I044563c1dd82a54b717f0c9a2d66e9dcc7a5b42c
---
M modules/openstack/files/novastats/proxyleaks.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/94/360994/1

diff --git a/modules/openstack/files/novastats/proxyleaks.py 
b/modules/openstack/files/novastats/proxyleaks.py
index 4694ae5..e90aadc 100755
--- a/modules/openstack/files/novastats/proxyleaks.py
+++ b/modules/openstack/files/novastats/proxyleaks.py
@@ -93,13 +93,13 @@
                     proxy_recordsets[recordset['name']] = recordset
 
     allinstances = clients.allinstances()
-    all_nova_ips = [instance.addresses['public'][0]['addr'] for instance in 
allinstances]
+    all_nova_ips = [instance.addresses['public'][0]['addr'] for instance in 
allinstances if 'public' in instance.addresses]
 
     for project in clients.allprojects():
         mappings = all_mappings(project.id)
         projectinstances = clients.allinstances(project.id)
 
-        all_project_ips = [instance.addresses['public'][0]['addr'] for 
instance in projectinstances]
+        all_project_ips = [instance.addresses['public'][0]['addr'] for 
instance in projectinstances if 'public' in instance.addresses]
 
         for mapping in mappings:
             backend_ip = mapping['backends'][0].split(":")[1].strip('/')

-- 
To view, visit https://gerrit.wikimedia.org/r/360994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I044563c1dd82a54b717f0c9a2d66e9dcc7a5b42c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to