Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361004 )
Change subject: Hygiene: remove gallery CSS
......................................................................
Hygiene: remove gallery CSS
The Android app shows images in a native gallery experience. This CSS
appears to be unnecessary.
Change-Id: I0d5ae40931d596c6fbf03cd39d69db369e74aab7
---
M app/src/main/assets/preview.css
M app/src/main/assets/styles.css
M scripts/make-css-assets.bash
3 files changed, 2 insertions(+), 436 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/04/361004/1
diff --git a/app/src/main/assets/preview.css b/app/src/main/assets/preview.css
index 72ab26b..03764cd 100644
--- a/app/src/main/assets/preview.css
+++ b/app/src/main/assets/preview.css
@@ -695,223 +695,6 @@
.timeline-wrapper {
max-width: 100%;
overflow: auto;
-}@media print {
- li.gallerybox {
- vertical-align: top;
- display: inline-block;
- }
-
- ul.gallery,
- li.gallerybox {
- zoom: 1;
- *display: inline;
- }
-
- ul.gallery {
- margin: 2px;
- padding: 2px;
- display: block;
- }
-
- li.gallerycaption {
- font-weight: bold;
- text-align: center;
- display: block;
- word-wrap: break-word;
- }
-
- li.gallerybox div.thumb {
- text-align: center;
- border: 1px solid #ccc;
- margin: 2px;
- }
-
- div.gallerytext {
- overflow: hidden;
- font-size: 94%;
- padding: 2px 4px;
- word-wrap: break-word;
- }}/* Galleries */
-/* These display attributes look nonsensical, but are needed to support IE and
FF2 */
-/* Don't forget to update gallery.print.css */
-li.gallerybox {
- vertical-align: top;
- display: -moz-inline-box;
- display: inline-block;
-}
-
-ul.gallery,
-li.gallerybox {
- zoom: 1;
- *display: inline;
-}
-
-ul.gallery {
- margin: 2px;
- padding: 2px;
- display: block;
-}
-
-li.gallerycaption {
- font-weight: bold;
- text-align: center;
- display: block;
- word-wrap: break-word;
-}
-
-li.gallerybox div.thumb {
- text-align: center;
- border: 1px solid #c8ccd1;
- background-color: #f8f9fa;
- margin: 2px;
-}
-
-li.gallerybox div.thumb img {
- display: block;
- margin: 0 auto;
-}
-
-div.gallerytext {
- overflow: hidden;
- font-size: 94%;
- padding: 2px 4px;
- word-wrap: break-word;
-}
-
-.galleryfilename {
- display: block;
-}
-
-.galleryfilename-truncate {
- white-space: nowrap;
- overflow: hidden;
- text-overflow: ellipsis;
-}
-
-/* new gallery stuff */
-ul.mw-gallery-nolines li.gallerybox div.thumb {
- background-color: transparent;
- border: 0;
-}
-
-ul.mw-gallery-nolines li.gallerybox div.gallerytext {
- text-align: center;
-}
-
-/* height constrained gallery */
-
-ul.mw-gallery-packed li.gallerybox div.thumb,
-ul.mw-gallery-packed-overlay li.gallerybox div.thumb,
-ul.mw-gallery-packed-hover li.gallerybox div.thumb {
- background-color: transparent;
- border: 0;
-}
-
-ul.mw-gallery-packed li.gallerybox div.thumb img,
-ul.mw-gallery-packed-overlay li.gallerybox div.thumb img,
-ul.mw-gallery-packed-hover li.gallerybox div.thumb img {
- margin: 0 auto;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox,
-ul.mw-gallery-packed-overlay li.gallerybox {
- position: relative;
-}
-
-ul.mw-gallery-packed-hover div.gallerytextwrapper {
- overflow: hidden;
- height: 0;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox:hover div.gallerytextwrapper,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper {
- position: absolute;
- background: #fff;
- background: rgba( 255, 255, 255, 0.8 );
- padding: 5px 10px;
- bottom: 0;
- left: 0; /* Needed for IE */
- height: auto;
- max-height: 40%;
- overflow: hidden;
- font-weight: bold;
- margin: 2px; /* correspond to style on div.thumb */
-}
-
-ul.mw-gallery-packed-hover li.gallerybox:hover div.gallerytextwrapper p,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper p,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper p {
- text-overflow: ellipsis;
- white-space: nowrap;
- overflow: hidden;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox div.gallerytextwrapper:hover,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper:hover,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper:hover {
- overflow: visible;
- max-height: none;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox div.gallerytextwrapper:hover p,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper:hover p,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper:hover p {
- text-overflow: clip;
- white-space: normal;
- overflow: visible;
-}
-
-ul.mw-gallery-packed-hover,
-ul.mw-gallery-packed-overlay,
-ul.mw-gallery-packed {
- text-align: center;
-}
-
-/* Slideshow */
-ul.gallery.mw-gallery-slideshow {
- display: block;
- margin: 4em 0;
-}
-
-ul.gallery.mw-gallery-slideshow .gallerycaption {
- font-size: 1.3em;
- margin: 0;
-}
-
-ul.gallery.mw-gallery-slideshow
.gallerycarousel.mw-gallery-slideshow-thumbnails-toggled {
- margin-bottom: 1.3em;
-}
-
-ul.gallery.mw-gallery-slideshow .mw-gallery-slideshow-buttons {
- opacity: 0.5;
- padding: 1.3em 0;
-}
-
-ul.gallery.mw-gallery-slideshow .mw-gallery-slideshow-buttons
.oo-ui-buttonElement {
- margin: 0 2em;
-}
-
-.mw-gallery-slideshow li.gallerybox.slideshow-current {
- background: #efefef;
-}
-
-.mw-gallery-slideshow .gallerybox > div {
- max-width: 120px;
-}
-
-ul.mw-gallery-slideshow li.gallerybox div.thumb {
- border: 0;
- background: transparent;
-}
-
-ul.mw-gallery-slideshow li.gallerycarousel {
- display: block;
- text-align: center;
-}
-
-.mw-gallery-slideshow-img-container a {
- display: block;
}.ipa_button {
display: inline-block;
margin-bottom: -3px;
diff --git a/app/src/main/assets/styles.css b/app/src/main/assets/styles.css
index 66ffae8..070b4d0 100644
--- a/app/src/main/assets/styles.css
+++ b/app/src/main/assets/styles.css
@@ -695,223 +695,6 @@
.timeline-wrapper {
max-width: 100%;
overflow: auto;
-}@media print {
- li.gallerybox {
- vertical-align: top;
- display: inline-block;
- }
-
- ul.gallery,
- li.gallerybox {
- zoom: 1;
- *display: inline;
- }
-
- ul.gallery {
- margin: 2px;
- padding: 2px;
- display: block;
- }
-
- li.gallerycaption {
- font-weight: bold;
- text-align: center;
- display: block;
- word-wrap: break-word;
- }
-
- li.gallerybox div.thumb {
- text-align: center;
- border: 1px solid #ccc;
- margin: 2px;
- }
-
- div.gallerytext {
- overflow: hidden;
- font-size: 94%;
- padding: 2px 4px;
- word-wrap: break-word;
- }}/* Galleries */
-/* These display attributes look nonsensical, but are needed to support IE and
FF2 */
-/* Don't forget to update gallery.print.css */
-li.gallerybox {
- vertical-align: top;
- display: -moz-inline-box;
- display: inline-block;
-}
-
-ul.gallery,
-li.gallerybox {
- zoom: 1;
- *display: inline;
-}
-
-ul.gallery {
- margin: 2px;
- padding: 2px;
- display: block;
-}
-
-li.gallerycaption {
- font-weight: bold;
- text-align: center;
- display: block;
- word-wrap: break-word;
-}
-
-li.gallerybox div.thumb {
- text-align: center;
- border: 1px solid #c8ccd1;
- background-color: #f8f9fa;
- margin: 2px;
-}
-
-li.gallerybox div.thumb img {
- display: block;
- margin: 0 auto;
-}
-
-div.gallerytext {
- overflow: hidden;
- font-size: 94%;
- padding: 2px 4px;
- word-wrap: break-word;
-}
-
-.galleryfilename {
- display: block;
-}
-
-.galleryfilename-truncate {
- white-space: nowrap;
- overflow: hidden;
- text-overflow: ellipsis;
-}
-
-/* new gallery stuff */
-ul.mw-gallery-nolines li.gallerybox div.thumb {
- background-color: transparent;
- border: 0;
-}
-
-ul.mw-gallery-nolines li.gallerybox div.gallerytext {
- text-align: center;
-}
-
-/* height constrained gallery */
-
-ul.mw-gallery-packed li.gallerybox div.thumb,
-ul.mw-gallery-packed-overlay li.gallerybox div.thumb,
-ul.mw-gallery-packed-hover li.gallerybox div.thumb {
- background-color: transparent;
- border: 0;
-}
-
-ul.mw-gallery-packed li.gallerybox div.thumb img,
-ul.mw-gallery-packed-overlay li.gallerybox div.thumb img,
-ul.mw-gallery-packed-hover li.gallerybox div.thumb img {
- margin: 0 auto;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox,
-ul.mw-gallery-packed-overlay li.gallerybox {
- position: relative;
-}
-
-ul.mw-gallery-packed-hover div.gallerytextwrapper {
- overflow: hidden;
- height: 0;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox:hover div.gallerytextwrapper,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper {
- position: absolute;
- background: #fff;
- background: rgba( 255, 255, 255, 0.8 );
- padding: 5px 10px;
- bottom: 0;
- left: 0; /* Needed for IE */
- height: auto;
- max-height: 40%;
- overflow: hidden;
- font-weight: bold;
- margin: 2px; /* correspond to style on div.thumb */
-}
-
-ul.mw-gallery-packed-hover li.gallerybox:hover div.gallerytextwrapper p,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper p,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper p {
- text-overflow: ellipsis;
- white-space: nowrap;
- overflow: hidden;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox div.gallerytextwrapper:hover,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper:hover,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper:hover {
- overflow: visible;
- max-height: none;
-}
-
-ul.mw-gallery-packed-hover li.gallerybox div.gallerytextwrapper:hover p,
-ul.mw-gallery-packed-overlay li.gallerybox div.gallerytextwrapper:hover p,
-ul.mw-gallery-packed-hover li.gallerybox.mw-gallery-focused
div.gallerytextwrapper:hover p {
- text-overflow: clip;
- white-space: normal;
- overflow: visible;
-}
-
-ul.mw-gallery-packed-hover,
-ul.mw-gallery-packed-overlay,
-ul.mw-gallery-packed {
- text-align: center;
-}
-
-/* Slideshow */
-ul.gallery.mw-gallery-slideshow {
- display: block;
- margin: 4em 0;
-}
-
-ul.gallery.mw-gallery-slideshow .gallerycaption {
- font-size: 1.3em;
- margin: 0;
-}
-
-ul.gallery.mw-gallery-slideshow
.gallerycarousel.mw-gallery-slideshow-thumbnails-toggled {
- margin-bottom: 1.3em;
-}
-
-ul.gallery.mw-gallery-slideshow .mw-gallery-slideshow-buttons {
- opacity: 0.5;
- padding: 1.3em 0;
-}
-
-ul.gallery.mw-gallery-slideshow .mw-gallery-slideshow-buttons
.oo-ui-buttonElement {
- margin: 0 2em;
-}
-
-.mw-gallery-slideshow li.gallerybox.slideshow-current {
- background: #efefef;
-}
-
-.mw-gallery-slideshow .gallerybox > div {
- max-width: 120px;
-}
-
-ul.mw-gallery-slideshow li.gallerybox div.thumb {
- border: 0;
- background: transparent;
-}
-
-ul.mw-gallery-slideshow li.gallerycarousel {
- display: block;
- text-align: center;
-}
-
-.mw-gallery-slideshow-img-container a {
- display: block;
}#issues_container div.hatnote {
display: none;
}
diff --git a/scripts/make-css-assets.bash b/scripts/make-css-assets.bash
index 2697aa1..47075e1 100755
--- a/scripts/make-css-assets.bash
+++ b/scripts/make-css-assets.bash
@@ -6,6 +6,6 @@
BASE_PATH="`dirname $0`/.."
-wget
"$PREFIX/load.php?debug=true&lang=en&modules=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mediawiki.page.gallery.styles|mobile.app.pagestyles.android|mediawiki.skinning.content.parsoid&only=styles&version=&*"
-O "$BASE_PATH/app/src/main/assets/styles.css"
-wget
"$PREFIX/load.php?debug=true&lang=en&modules=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mediawiki.page.gallery.styles|mobile.app.preview.android|mobile.app.preview|mediawiki.skinning.content.parsoid&only=styles&version=&*"
-O "$BASE_PATH/app/src/main/assets/preview.css"
+wget
"$PREFIX/load.php?debug=true&lang=en&modules=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mobile.app.pagestyles.android|mediawiki.skinning.content.parsoid&only=styles&version=&*"
-O "$BASE_PATH/app/src/main/assets/styles.css"
+wget
"$PREFIX/load.php?debug=true&lang=en&modules=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mobile.app.preview.android|mobile.app.preview|mediawiki.skinning.content.parsoid&only=styles&version=&*"
-O "$BASE_PATH/app/src/main/assets/preview.css"
wget
"$PREFIX/load.php?debug=true&lang=en&modules=mobile.app.pagestyles.android.night&only=styles&version=&*"
-O "$BASE_PATH/app/src/main/assets/dark.css"
--
To view, visit https://gerrit.wikimedia.org/r/361004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d5ae40931d596c6fbf03cd39d69db369e74aab7
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
