WMDE-leszek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361072 )

Change subject: Make readFullEntityIdColumn enabled by default
......................................................................

Make readFullEntityIdColumn enabled by default

The full entity ID column will be populated during schema update
(update.php), so Wikibase instances should be fine to use the
new full ID column. Wikibase instances should in general
use the full ID column unless there is any reason to not
populate the column using update script.

DEPLOYMENT: when deploying this for Wikidata make sure
readFullEntityIdColumn is set to false in local settings,
as Wikidata does not use a script to populate the column.

Change-Id: I8f8c16e7a2e105571ba23d8e157471dc2e668273
---
M client/config/WikibaseClient.default.php
M repo/config/Wikibase.default.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/72/361072/1

diff --git a/client/config/WikibaseClient.default.php 
b/client/config/WikibaseClient.default.php
index d382474..1e272ff 100644
--- a/client/config/WikibaseClient.default.php
+++ b/client/config/WikibaseClient.default.php
@@ -224,7 +224,7 @@
        $defaults['tabularDataStorageBaseUrl'] = 
'https://commons.wikimedia.org/wiki/';
 
        // Enable reading of term_full_entity_id column in wb_terms table.
-       $defaults['readFullEntityIdColumn'] = false;
+       $defaults['readFullEntityIdColumn'] = true;
 
        return $defaults;
 } );
diff --git a/repo/config/Wikibase.default.php b/repo/config/Wikibase.default.php
index 6595f52..a338af6 100644
--- a/repo/config/Wikibase.default.php
+++ b/repo/config/Wikibase.default.php
@@ -232,5 +232,5 @@
        },
 
        // Enable reading of term_full_entity_id column in wb_terms table.
-       'readFullEntityIdColumn' => false,
+       'readFullEntityIdColumn' => true,
 ];

-- 
To view, visit https://gerrit.wikimedia.org/r/361072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f8c16e7a2e105571ba23d8e157471dc2e668273
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to