SamanthaNguyen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361203 )
Change subject: [WIP] Improve color contrast for Echo icons in bundled dark themes ...................................................................... [WIP] Improve color contrast for Echo icons in bundled dark themes - Both icons bundled here, tray.svg and bell.svg have been modified from their original source to improve the color contrast against the dark themes. - tray.svg - https://github.com/wikimedia/oojs-ui/blob/master/src/themes/wikimediaui/images/icons/tray.svg - bell.svg - https://github.com/wikimedia/oojs-ui/blob/master/src/themes/wikimediaui/images/icons/bell.svg TODO: Convert to use ResourceLoaderImageModule or ResourceLoaderOOUIIMageModule(?) Change-Id: I0f0d54eb2ee531f303d69699429640c831d030be --- M extension.json A icons/bell.svg A icons/tray.svg A modules/ext.echo.dark.css 4 files changed, 31 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Theme refs/changes/03/361203/1 diff --git a/extension.json b/extension.json index 9691581..c9dc16c 100644 --- a/extension.json +++ b/extension.json @@ -1,7 +1,7 @@ { "name": "Theme", "namemsg": "theme-extensionname", - "version": "1.8.0", + "version": "1.9.0", "author": [ "Ryan Schmidt", "Jack Phoenix", @@ -19,12 +19,22 @@ "ThemeHooks": "Theme.hooks.php" }, "ResourceModules": { + "ext.echo.dark" : { + "styles": { + "modules/ext.echo.dark.css": { + "media": "screen" + } + } + }, "themeloader.skins.monobook.dark": { "styles": { "monobook/dark.css": { "media": "screen" } - } + }, + "dependencies": [ + "ext.echo.dark" + ] }, "themeloader.skins.monobook.pink": { "styles": { @@ -48,7 +58,10 @@ "vector/dark/dark.special.preferences.styles.less": { "media": "screen" } - } + }, + "dependencies": [ + "ext.echo.dark" + ] }, "themeloader.skins.vector.deepsea": { "styles": { diff --git a/icons/bell.svg b/icons/bell.svg new file mode 100644 index 0000000..d2662fc --- /dev/null +++ b/icons/bell.svg @@ -0,0 +1,4 @@ +<?xml version="1.0" encoding="utf-8"?> +<svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24" fill="#f8f9fa"> + <path d="M17.5 13V8c0-3-2.3-5-5.5-5S6.5 5 6.5 8v5c0 2 0 3-2 3v1h15v-1c-2 0-2-1-2-3zM12 19H9c0 1 1.6 2 3 2s3-1 3-2h-3z"/> +</svg> diff --git a/icons/tray.svg b/icons/tray.svg new file mode 100644 index 0000000..8a8a672 --- /dev/null +++ b/icons/tray.svg @@ -0,0 +1,4 @@ +<?xml version="1.0" encoding="utf-8"?> +<svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24" fill="#f8f9fa"> + <path d="M3 13.35l1.8-7.2c.2-.996.81-1.8 1.8-1.8h10.8c.99 0 1.6.867 1.8 1.8l1.8 7.2v4.5c0 .99-.81 1.8-1.8 1.8H4.8c-.99 0-1.8-.81-1.8-1.8v-4.5zm6.96 1.8h4.08c-.49.557-1.212.9-2.04.9a2.68 2.68 0 0 1-2.04-.9h4.08c.414-.472.66-1.098.66-1.8h4.14l-1.44-7.2H6.6l-1.44 7.2H9.3c0 .702.246 1.328.66 1.8z" id="tray"/> +</svg> diff --git a/modules/ext.echo.dark.css b/modules/ext.echo.dark.css new file mode 100644 index 0000000..cf78833 --- /dev/null +++ b/modules/ext.echo.dark.css @@ -0,0 +1,7 @@ +#pt-notifications-alert .mw-echo-notifications-badge:before { + background-image: url(../icons/bell.svg); +} + +#pt-notifications-notice .mw-echo-notifications-badge:before { + background-image: url(../icons/tray.svg); +} -- To view, visit https://gerrit.wikimedia.org/r/361203 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f0d54eb2ee531f303d69699429640c831d030be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Theme Gerrit-Branch: master Gerrit-Owner: SamanthaNguyen <samanthanguyen1...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
