Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361213 )

Change subject: Skip blank translation on export
......................................................................

Skip blank translation on export

Bug: T155182
Change-Id: I08e5f009749828050de4962274136004d46aa6a2
---
M ffs/JsonFFS.php
M ffs/MediaWikiExtensionFFS.php
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/13/361213/1

diff --git a/ffs/JsonFFS.php b/ffs/JsonFFS.php
index 24d3f71..79e85db 100644
--- a/ffs/JsonFFS.php
+++ b/ffs/JsonFFS.php
@@ -108,6 +108,11 @@
                                $value = str_replace( TRANSLATE_FUZZY, '', 
$value );
                        }
 
+                       // Skip blank translation - T155182
+                       if ( $value === '' ) {
+                               continue;
+                       }
+
                        $key = $mangler->unmangle( $key );
                        $messages[$key] = $value;
                }
diff --git a/ffs/MediaWikiExtensionFFS.php b/ffs/MediaWikiExtensionFFS.php
index a1aef9d..ff2e2ae 100644
--- a/ffs/MediaWikiExtensionFFS.php
+++ b/ffs/MediaWikiExtensionFFS.php
@@ -219,6 +219,12 @@
 
                        $key = $mangler->unmangle( $key );
                        $value = str_replace( TRANSLATE_FUZZY, '', $value );
+
+                       // Skip blank translation - T155182
+                       if ( $value === '' ) {
+                               continue;
+                       }
+
                        $fuzzy = $m->hasTag( 'fuzzy' ) ? ' # Fuzzy' : '';
 
                        $key = self::quote( $key );

-- 
To view, visit https://gerrit.wikimedia.org/r/361213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08e5f009749828050de4962274136004d46aa6a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to