jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360207 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: I440356e290f3e3c3eb0087940bea82e7a3bdcc84
---
M QuickArrayReader.php
M Updater.php
M composer.json
M fetcher/FetcherFactory.php
M phpcs.xml
5 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/QuickArrayReader.php b/QuickArrayReader.php
index c96bab4..d8b7972 100644
--- a/QuickArrayReader.php
+++ b/QuickArrayReader.php
@@ -212,4 +212,3 @@
}
}
}
-
diff --git a/Updater.php b/Updater.php
index 456c9bc..7f0c21f 100644
--- a/Updater.php
+++ b/Updater.php
@@ -86,7 +86,7 @@
*
* @param array $origin
* @param array $remote
- * @param array [$blacklist] Array of message keys to ignore, keys as
as array keys.
+ * @param array $blacklist Array of message keys to ignore, keys as as
array keys.
* @return array
*/
public function findChangedTranslations( $origin, $remote, $blacklist =
[] ) {
@@ -129,7 +129,6 @@
FetcherFactory $fetcherFactory,
array $repos
) {
-
$components = $finder->getComponents();
$updatedMessages = [];
diff --git a/composer.json b/composer.json
index 3e1e6a7..d5696b9 100644
--- a/composer.json
+++ b/composer.json
@@ -33,7 +33,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.9.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/fetcher/FetcherFactory.php b/fetcher/FetcherFactory.php
index e772a4e..570dc7e 100644
--- a/fetcher/FetcherFactory.php
+++ b/fetcher/FetcherFactory.php
@@ -12,7 +12,6 @@
*/
class FetcherFactory {
public function getFetcher( $path ) {
-
if ( strpos( $path, 'https://raw.github.com/' ) === 0 ) {
return new GitHubFetcher();
} elseif ( strpos( $path, 'http://' ) === 0 ) {
diff --git a/phpcs.xml b/phpcs.xml
index d81a292..d6ca3ea 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,8 +1,16 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+ </rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="UTF-8" />
<exclude-pattern>vendor</exclude-pattern>
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/360207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I440356e290f3e3c3eb0087940bea82e7a3bdcc84
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/LocalisationUpdate
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
