Mooeypoo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361605 )
Change subject: RCFilters: Make extra filters footer non-sticky ...................................................................... RCFilters: Make extra filters footer non-sticky Bug: T168851 Change-Id: I504847e4b07d473786a4026b053a55ae460897e8 --- M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/05/361605/1 diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js index 70381f2..0ab459e 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js @@ -47,6 +47,7 @@ footers: [ { name: 'viewSelect', + sticky: false, // View select menu, appears on default view only $element: $( '<div>' ) .append( new mw.rcfilters.ui.ViewSwitchWidget( this.controller, this.model ).$element ), diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js index c70e00b..05c69d9 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js @@ -82,7 +82,8 @@ // based on view config.footers = config.footers || []; config.footers.forEach( function ( footerData ) { - var adjustedData = { + var isSticky = footerData.sticky === undefined ? true : !!footerData.sticky, + adjustedData = { // Wrap the element with our own footer wrapper $element: $( '<div>' ) .addClass( 'mw-rcfilters-ui-menuSelectWidget-footer' ) @@ -92,7 +93,12 @@ }; this.footers.push( adjustedData ); - this.$element.append( adjustedData.$element ); + + if ( isSticky ) { + this.$element.append( adjustedData.$element ); + } else { + this.$body.append( adjustedData.$element ); + } }.bind( this ) ); // Switch to the correct view -- To view, visit https://gerrit.wikimedia.org/r/361605 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I504847e4b07d473786a4026b053a55ae460897e8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits