Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361684 )
Change subject: Fix dark mode presentation of reading list item overflow dialog.
......................................................................
Fix dark mode presentation of reading list item overflow dialog.
The background color of this item was never being set correctly, so it was
appearing as the default white, even in dark mode.
Change-Id: I74eeb6190812196f6589d8f0adeb073825583630
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsDialog.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/84/361684/1
diff --git
a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsDialog.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsDialog.java
index f23a7b3..70cce67 100644
---
a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsDialog.java
+++
b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsDialog.java
@@ -3,13 +3,16 @@
import android.os.Bundle;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
+import android.support.v4.content.ContextCompat;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
+import org.wikipedia.R;
import org.wikipedia.activity.FragmentUtil;
import org.wikipedia.page.ExtendedBottomSheetDialogFragment;
import org.wikipedia.readinglist.page.ReadingListPage;
+import org.wikipedia.util.ResourceUtil;
public class ReadingListItemActionsDialog extends
ExtendedBottomSheetDialogFragment {
public interface Callback {
@@ -40,6 +43,8 @@
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
actionsView = new ReadingListItemActionsView(getContext());
+ actionsView.setBackgroundColor(ContextCompat.getColor(getContext(),
+ ResourceUtil.getThemedAttributeId(getContext(),
R.attr.bottom_sheet_background_color)));
actionsView.setCallback(itemActionsCallback);
pageIndex = getArguments().getInt("pageIndex");
actionsView.setState(getArguments().getString("pageTitle", ""),
--
To view, visit https://gerrit.wikimedia.org/r/361684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74eeb6190812196f6589d8f0adeb073825583630
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
