Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361945 )
Change subject: Revert "Run DiffViewHeader in mobile mode, too"
......................................................................
Revert "Run DiffViewHeader in mobile mode, too"
This reverts commit 10682d2ebedf5f826920cffb042bd567b8c1ae14.
The onDiffViewHeader hook loads code in the RevisionSlider which
is not mobile ready.
Bug: T169024
Change-Id: I5421214b4dea7935ee541b4091c195bce0872a84
---
M includes/specials/SpecialMobileDiff.php
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/45/361945/1
diff --git a/includes/specials/SpecialMobileDiff.php
b/includes/specials/SpecialMobileDiff.php
index a2dc4a4..e109baf 100644
--- a/includes/specials/SpecialMobileDiff.php
+++ b/includes/specials/SpecialMobileDiff.php
@@ -245,11 +245,6 @@
$comment
)
);
-
- if ( $this->mDiffEngine instanceof InlineDifferenceEngine ) {
- // TODO: The hook gets originally called in the
DifferenceEngine::showDiffPage() method
- Hooks::run( 'DiffViewHeader', [ $this->mDiffEngine,
$this->prevRev, $this->rev ] );
- }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/361945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5421214b4dea7935ee541b4091c195bce0872a84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
