Mooeypoo has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362105 )
Change subject: RCFilters: Followup I200720ffde8ad: Hide extended footer if
gater is disabled
......................................................................
RCFilters: Followup I200720ffde8ad: Hide extended footer if gater is disabled
Bug: T169163
Change-Id: I62f63cbf06a7e42864faca1a196903eb34ea077b
---
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/362105/1
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index 0ab459e..9671f5e 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@ -47,6 +47,7 @@
footers: [
{
name: 'viewSelect',
+ disabled: !mw.config.get(
'wgStructuredChangeFiltersEnableExperimentalViews' ),
sticky: false,
// View select menu, appears on
default view only
$element: $( '<div>' )
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
index c12e10e..d9a1822 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
@@ -92,12 +92,14 @@
views: footerData.views
};
- this.footers.push( adjustedData );
+ if ( !footerData.disabled ) {
+ this.footers.push( adjustedData );
- if ( isSticky ) {
- this.$element.append( adjustedData.$element );
- } else {
- this.$body.append( adjustedData.$element );
+ if ( isSticky ) {
+ this.$element.append(
adjustedData.$element );
+ } else {
+ this.$body.append(
adjustedData.$element );
+ }
}
}.bind( this ) );
--
To view, visit https://gerrit.wikimedia.org/r/362105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62f63cbf06a7e42864faca1a196903eb34ea077b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
