Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362117 )
Change subject: jsminplus: Fix JSNode memory leak from 'continue' statements
......................................................................
jsminplus: Fix JSNode memory leak from 'continue' statements
During parsing of scripts containing a 'continue' statement,
the JSNode for that statements, and all containing blocks (e.g. conditional
blocks, for-loop/white-loop statements , etc.) were being held
in memory indefinitely.
Bug: T31784
Change-Id: Id7006c264a470ba665434f6f275e49a1516b73ae
---
M includes/libs/jsminplus.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/17/362117/1
diff --git a/includes/libs/jsminplus.php b/includes/libs/jsminplus.php
index 40f22c5..7feac7d 100644
--- a/includes/libs/jsminplus.php
+++ b/includes/libs/jsminplus.php
@@ -973,8 +973,6 @@
}
while (!$ss[$i]->isLoop && ($tt !=
KEYWORD_BREAK || $ss[$i]->type != KEYWORD_SWITCH));
}
-
- $n->target = $ss[$i];
break;
case KEYWORD_TRY:
--
To view, visit https://gerrit.wikimedia.org/r/362117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7006c264a470ba665434f6f275e49a1516b73ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
