jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362110 )
Change subject: RCFilters: Followup I200720ffde8ad: Hide extended footer if
gater is disabled
......................................................................
RCFilters: Followup I200720ffde8ad: Hide extended footer if gater is disabled
Bug: T169163
Change-Id: I62f63cbf06a7e42864faca1a196903eb34ea077b
---
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index 70381f2..dc1556b 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@ -47,6 +47,7 @@
footers: [
{
name: 'viewSelect',
+ disabled: !mw.config.get(
'wgStructuredChangeFiltersEnableExperimentalViews' ),
// View select menu, appears on
default view only
$element: $( '<div>' )
.append( new
mw.rcfilters.ui.ViewSwitchWidget( this.controller, this.model ).$element ),
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
index 74f8bcd..1c808d4 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
@@ -91,8 +91,10 @@
views: footerData.views
};
- this.footers.push( adjustedData );
- this.$element.append( adjustedData.$element );
+ if ( !footerData.disabled ) {
+ this.footers.push( adjustedData );
+ this.$element.append( adjustedData.$element );
+ }
}.bind( this ) );
// Switch to the correct view
--
To view, visit https://gerrit.wikimedia.org/r/362110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62f63cbf06a7e42864faca1a196903eb34ea077b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
