Giuseppe Lavagetto has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362428 )
Change subject: Do not rebuild already built images
......................................................................
Do not rebuild already built images
Change-Id: Iaadd63daea90f15519fbaf7e7adf39e7e40f4778
---
M build
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Giuseppe Lavagetto: Verified; Looks good to me, approved
diff --git a/build b/build
index 7ee8dfd..c9d2af8 100755
--- a/build
+++ b/build
@@ -87,6 +87,13 @@
)
yield DockerImage(root, self.config, self.base_directory)
+ def image_exists(self, image):
+ try:
+ self.client.images.get("{}:{}".format(image.name, image.tag))
+ return True
+ except docker.errors.ImageNotFound:
+ return False
+
def build(self, image):
print('Building image {name}:{version}'.format(name=image.name,
version=image.tag))
image_ref = "{name}:{tag}".format(name=image.name, tag=image.tag)
@@ -120,6 +127,8 @@
def main(args):
db = DockerBuilder(args.directory, args.configfile)
for image in db.scan():
+ if db.image_exists(image):
+ continue
for name, tag in db.build(image):
known_images[image.name] = image
db.publish(name, tag)
--
To view, visit https://gerrit.wikimedia.org/r/362428
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaadd63daea90f15519fbaf7e7adf39e7e40f4778
Gerrit-PatchSet: 1
Gerrit-Project: operations/docker-images/production-images
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
