Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362459 )
Change subject: ResourceLoaderSkinModule should default to mobile and desktop
target
......................................................................
ResourceLoaderSkinModule should default to mobile and desktop target
If a skin is using this, it's likely to be pretty new.
The targets system was mostly created for older code.
Let's make this the default so skins don't need to do anything
additional to work on mobile
This simple change makes the Timeless skin work on mobile
when MobileFrontend is installed: ?useformat=mobile&useskin=timeless
It looks beautiful :)
Change-Id: I2ab8a1a634bdc0b5b2084d227c7388b5382e93e8
---
M includes/resourceloader/ResourceLoaderSkinModule.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/59/362459/1
diff --git a/includes/resourceloader/ResourceLoaderSkinModule.php
b/includes/resourceloader/ResourceLoaderSkinModule.php
index 5740925..1d0a333 100644
--- a/includes/resourceloader/ResourceLoaderSkinModule.php
+++ b/includes/resourceloader/ResourceLoaderSkinModule.php
@@ -22,6 +22,11 @@
*/
class ResourceLoaderSkinModule extends ResourceLoaderFileModule {
+ /**
+ * All skins are assumed to be compatible with mobile
+ * @inheritdoc
+ */
+ public $targets = [ "desktop", "mobile" ];
/**
* @param ResourceLoaderContext $context
--
To view, visit https://gerrit.wikimedia.org/r/362459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab8a1a634bdc0b5b2084d227c7388b5382e93e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
