Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362461 )
Change subject: Make Timeless compatible with MobileFrontend ...................................................................... Make Timeless compatible with MobileFrontend I'm giving you some attention on Extension:MobileFrontend page and want to promote skins which look nice on mobile. https://www.mediawiki.org/wiki/Extension:MobileFrontend#Setup_a_skin The targets are needed to ensure code is loaded by the skin when operating in mobile mode so currently that wiki page is lying. Please let it be true :) Change-Id: Ie9ba6beec172f7b499ae347652318fe54d258e39 --- M skin.json 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless refs/changes/61/362461/1 diff --git a/skin.json b/skin.json index 5e38aa2..28c87d1 100644 --- a/skin.json +++ b/skin.json @@ -17,6 +17,7 @@ }, "ResourceModules": { "skins.timeless": { + "targets": [ "desktop", "mobile" ], "position": "top", "class": "ResourceLoaderSkinModule", "styles": { @@ -51,18 +52,21 @@ "@NOTE": "Remember to also update variables.less if you change the width cutoffs here. screen-misc.less and mobile.js may also need updating." }, "skins.timeless.misc": { + "targets": [ "desktop", "mobile" ], "position": "top", "styles": [ "resources/screen-misc.less" ] }, "skins.timeless.js": { + "targets": [ "desktop", "mobile" ], "position": "bottom", "scripts": [ "resources/main.js" ] }, "skins.timeless.mobile": { + "targets": [ "desktop", "mobile" ], "position": "bottom", "scripts": [ "resources/libraries/jquery.mobile.custom.js", -- To view, visit https://gerrit.wikimedia.org/r/362461 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9ba6beec172f7b499ae347652318fe54d258e39 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Timeless Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
