DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363034 )
Change subject: ui.WhitespacePreservingTextInputWidget: inherit from
MultilineTextInputWidget
......................................................................
ui.WhitespacePreservingTextInputWidget: inherit from MultilineTextInputWidget
Commit 1eb25592c to OOui removed multiline support from TextInputWidget. All
uses of WhitespacePreservingTextInputWidget require multiline, and caused
errors instead of functioning.
Bug: T169272
Change-Id: I3e510aa9b44f2ad37f8ff026d680df446925e8ee
---
M src/ui/inspectors/ve.ui.CommentInspector.js
M src/ui/widgets/ve.ui.WhitespacePreservingTextInputWidget.js
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/34/363034/1
diff --git a/src/ui/inspectors/ve.ui.CommentInspector.js
b/src/ui/inspectors/ve.ui.CommentInspector.js
index 2d9c5ac..c6d27c1 100644
--- a/src/ui/inspectors/ve.ui.CommentInspector.js
+++ b/src/ui/inspectors/ve.ui.CommentInspector.js
@@ -52,7 +52,6 @@
ve.ui.CommentInspector.super.prototype.initialize.call( this );
this.textWidget = new ve.ui.WhitespacePreservingTextInputWidget( {
- multiline: true,
autosize: true
} );
this.textWidget.connect( this, { resize: 'updateSize' } );
diff --git a/src/ui/widgets/ve.ui.WhitespacePreservingTextInputWidget.js
b/src/ui/widgets/ve.ui.WhitespacePreservingTextInputWidget.js
index 2be7710..3cd654b 100644
--- a/src/ui/widgets/ve.ui.WhitespacePreservingTextInputWidget.js
+++ b/src/ui/widgets/ve.ui.WhitespacePreservingTextInputWidget.js
@@ -8,7 +8,7 @@
* Text input widget which hides but preserves leading and trailing whitespace
*
* @class
- * @extends OO.ui.TextInputWidget
+ * @extends OO.ui.MultilineTextInputWidget
*
* @constructor
* @param {Object} [config] Configuration options
@@ -32,7 +32,7 @@
/* Inheritance */
-OO.inheritClass( ve.ui.WhitespacePreservingTextInputWidget,
OO.ui.TextInputWidget );
+OO.inheritClass( ve.ui.WhitespacePreservingTextInputWidget,
OO.ui.MultilineTextInputWidget );
/* Methods */
--
To view, visit https://gerrit.wikimedia.org/r/363034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e510aa9b44f2ad37f8ff026d680df446925e8ee
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <dly...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
