Bearloga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363365 )
Change subject: [Sister Search] Add no split option
......................................................................
[Sister Search] Add no split option
Bug: T164854
Change-Id: I1fc9c460fb626d762b639cdf03dfc597812de5b9
---
M server.R
M ui.R
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/rainbow
refs/changes/65/363365/1
diff --git a/server.R b/server.R
index 92e94c1..49c429b 100644
--- a/server.R
+++ b/server.R
@@ -365,6 +365,10 @@
output$sister_search_traffic_plot <- renderDygraph({
switch(
input$sister_search_traffic_split,
+ "none" = {
+ sister_search_traffic %>%
+ dplyr::mutate(split = "Sister search traffic")
+ },
"project" = {
sister_search_traffic %>%
dplyr::rename(split = project)
diff --git a/ui.R b/ui.R
index c9fb719..cefcb03 100644
--- a/ui.R
+++ b/ui.R
@@ -276,7 +276,7 @@
tabItem(tabName = "sister_search_traffic",
fluidRow(
column(polloi::smooth_select("smoothing_sister_search_traffic_plot"), width =
3),
- column(shiny::radioButtons("sister_search_traffic_split",
"Split pageviews by", choices = list("Project" = "project", "Search results
pages vs Articles*" = "destination", "English vs other languages†" =
"language", "Desktop vs Mobile Web" = "access_method"), inline = TRUE), width =
9)
+ column(shiny::radioButtons("sister_search_traffic_split",
"Split pageviews by", choices = list("None" = "none", "Project" = "project",
"Search results pages vs Articles*" = "destination", "English vs other
languages†" = "language", "Desktop vs Mobile Web" = "access_method"), inline =
TRUE, selected = "none"), width = 9)
),
dygraphOutput("sister_search_traffic_plot"),
div(id = "sister_search_traffic_plot_legend"),
--
To view, visit https://gerrit.wikimedia.org/r/363365
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fc9c460fb626d762b639cdf03dfc597812de5b9
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/rainbow
Gerrit-Branch: develop
Gerrit-Owner: Bearloga <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
