Reedy has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363387 )
Change subject: Swap isset() === false to !isset() ...................................................................... Swap isset() === false to !isset() Change-Id: I9513722b3670e61e177946f7f8fa01ff053bfe73 --- M MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer refs/changes/87/363387/2 diff --git a/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php b/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php index a2cf1e7..ec0ea03 100644 --- a/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php +++ b/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php @@ -28,8 +28,8 @@ public function process( File $phpcsFile, $stackPtr ) { $tokens = $phpcsFile->getTokens(); $current = $tokens[$stackPtr]; - if ( isset( $current['scope_opener'] ) === false || - isset( $current['parenthesis_closer'] ) === false + if ( !isset( $current['scope_opener'] ) || + !isset( $current['parenthesis_closer'] ) ) { return; } -- To view, visit https://gerrit.wikimedia.org/r/363387 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9513722b3670e61e177946f7f8fa01ff053bfe73 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Reedy <re...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits