Elukey has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/363791 )
Change subject: redis::monitoring::nrpe_instance: set retry_interval to 2 mins ...................................................................... redis::monitoring::nrpe_instance: set retry_interval to 2 mins By default this check is retried 3 times with a retry_interval of 1 min. When a slave restarts and issue a SYNC to the master it will take a couple of minutes for it to bootstrap correctly (sync with the master and load data in memory). This new setting should remove daily false positives due to Redis instance reboots (and similar use cases). Change-Id: Ie05d8a093389169098db0cb307c968a5284fa5fd --- M modules/redis/manifests/monitoring/nrpe_instance.pp 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Alexandros Kosiaris: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/redis/manifests/monitoring/nrpe_instance.pp b/modules/redis/manifests/monitoring/nrpe_instance.pp index b1cae23..e5554b8 100644 --- a/modules/redis/manifests/monitoring/nrpe_instance.pp +++ b/modules/redis/manifests/monitoring/nrpe_instance.pp @@ -3,9 +3,10 @@ $port = $title $cmd = $::redis::monitoring::nrpe::nrpe_command nrpe::monitor_service { "redis_status_on_port_${port}": - ensure => present, - description => "Check health of redis instance on ${port}", - nrpe_command => "/usr/bin/sudo ${cmd} ${port} ${replica_warning} ${replica_critical}", - contact_group => 'admins', + ensure => present, + description => "Check health of redis instance on ${port}", + nrpe_command => "/usr/bin/sudo ${cmd} ${port} ${replica_warning} ${replica_critical}", + contact_group => 'admins', + retry_interval => 2, } } -- To view, visit https://gerrit.wikimedia.org/r/363791 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie05d8a093389169098db0cb307c968a5284fa5fd Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Elukey <ltosc...@wikimedia.org> Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org> Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits