Jonas Kress (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364380 )
Change subject: [WIP] Use rdfs:label instead of wikibase:label
......................................................................
[WIP] Use rdfs:label instead of wikibase:label
When query is SELECT * it is not possible to use wikibase:label
without adding the variable. To support this we switch over to
rdfs:label instead.
Change-Id: Ic4882643458d154f7c201ef208aba56d3d076212
---
M wikibase/queryService/ui/queryHelper/QueryHelper.js
1 file changed, 4 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/80/364380/1
diff --git a/wikibase/queryService/ui/queryHelper/QueryHelper.js
b/wikibase/queryService/ui/queryHelper/QueryHelper.js
index 4229ebe..ff7342d 100644
--- a/wikibase/queryService/ui/queryHelper/QueryHelper.js
+++ b/wikibase/queryService/ui/queryHelper/QueryHelper.js
@@ -552,15 +552,10 @@
return true;//close popover
},
tag: function() {
- if ( triple.triple.object.startsWith(
'?' ) ) {
- self._query
- .addVariable(
triple.triple.object +
-
'Label' );
- } else {
- self._query
- .addVariable(
triple.triple.subject +
-
'Label' );
- }
+ var variable =
triple.triple.object.startsWith( '?' ) ?
+ triple.triple.object :
triple.triple.subject;
+
+ self._query.addTriple( variable,
'rdfs:label', variable + 'Label', true );
if ( self._changeListener ) {
self._changeListener( self );
}
--
To view, visit https://gerrit.wikimedia.org/r/364380
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4882643458d154f7c201ef208aba56d3d076212
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
