jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/364126 )
Change subject: Use LogFormatter::getLinkRenderer in NewsletterLogFormatter ...................................................................... Use LogFormatter::getLinkRenderer in NewsletterLogFormatter This raises MediaWiki version requirement to 1.30.0 and bumps the version number to 1.2.1. Change-Id: I354ad01e577cefe2059112f3e1aeea60029d42b7 --- M Newsletter.php M extension.json M includes/logging/NewsletterLogFormatter.php 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/Newsletter.php b/Newsletter.php index 5bb248a..77883be 100755 --- a/Newsletter.php +++ b/Newsletter.php @@ -11,5 +11,5 @@ ); */ return true; } else { - die( 'This version of the Newsletter extension requires MediaWiki 1.25+' ); + die( 'This version of the Newsletter extension requires MediaWiki 1.30+' ); } diff --git a/extension.json b/extension.json index 96fe06b..6d6e59a 100644 --- a/extension.json +++ b/extension.json @@ -1,6 +1,6 @@ { "name": "Newsletter", - "version": "1.2.0", + "version": "1.2.1", "author": [ "Siebrand Mazeland", "Tina Johnson", @@ -9,6 +9,9 @@ "url": "https://www.mediawiki.org/wiki/Extension:Newsletter", "descriptionmsg": "newsletter-extension-desc", "license-name": "GPL-2.0", + "requires": { + "MediaWiki": ">= 1.30.0" + }, "type": "other", "AvailableRights": [ "newsletter-create", @@ -92,7 +95,6 @@ "EchoNewsletterPublisherPresentationModel": "includes/Echo/EchoNewsletterPublisherPresentationModel.php", "EchoNewsletterUnsubscribedPresentationModel": "includes/Echo/EchoNewsletterUnsubscribedPresentationModel.php", "EchoNewsletterSubscribedPresentationModel": "includes/Echo/EchoNewsletterSubscribedPresentationModel.php" - }, "DefaultUserOptions": { "echo-subscriptions-web-newsletter": true, diff --git a/includes/logging/NewsletterLogFormatter.php b/includes/logging/NewsletterLogFormatter.php index 86c8562..8770efa 100644 --- a/includes/logging/NewsletterLogFormatter.php +++ b/includes/logging/NewsletterLogFormatter.php @@ -7,8 +7,6 @@ * @author Tyler Romeo */ -use MediaWiki\MediaWikiServices; - class NewsletterLogFormatter extends LogFormatter { /** * Reformat the target as a user link if the target was a user @@ -46,7 +44,7 @@ list( $id, $name ) = explode( ':', $value, 2 ); $title = SpecialPage::getTitleFor( 'Newsletter', $id ); if ( !$this->plaintext ) { - return Message::rawParam( MediaWikiServices::getInstance()->getLinkRenderer()->makeLink( + return Message::rawParam( $this->getLinkRenderer()->makeLink( $title, $name, [] -- To view, visit https://gerrit.wikimedia.org/r/364126 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I354ad01e577cefe2059112f3e1aeea60029d42b7 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Newsletter Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com> Gerrit-Reviewer: 01tonythomas <01tonytho...@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits