WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365230 )
Change subject: Rename incorrectly named Api\SetAliases and Api\SetDescription tests ...................................................................... Rename incorrectly named Api\SetAliases and Api\SetDescription tests Change-Id: I4ad64c53875a82980e0c441681f9fca88f04c1ec --- M repo/tests/phpunit/includes/Api/SetAliasesTest.php M repo/tests/phpunit/includes/Api/SetDescriptionTest.php 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/30/365230/1 diff --git a/repo/tests/phpunit/includes/Api/SetAliasesTest.php b/repo/tests/phpunit/includes/Api/SetAliasesTest.php index a7ce46a..c64df6a 100644 --- a/repo/tests/phpunit/includes/Api/SetAliasesTest.php +++ b/repo/tests/phpunit/includes/Api/SetAliasesTest.php @@ -258,7 +258,7 @@ $this->doTestSetTermExceptions( $params, $expected ); } - public function testUserCanEditWhenTheyHaveSufficientPermission() { + public function testUserCanSetAliasesWhenTheyHaveSufficientPermission() { $userWithAllPermissions = $this->createUserWithGroup( 'all-permission' ); $this->setMwGlobals( 'wgGroupPermissions', [ @@ -277,7 +277,7 @@ $this->assertEquals( 1, $result['success'] ); } - public function testUserCannotSetLabelWhenTheyLackPermission() { + public function testUserCannotSetAliasesWhenTheyLackPermission() { $userWithInsufficientPermissions = $this->createUserWithGroup( 'no-permission' ); $userWithAllPermissions = $this->createUserWithGroup( 'all-permission' ); diff --git a/repo/tests/phpunit/includes/Api/SetDescriptionTest.php b/repo/tests/phpunit/includes/Api/SetDescriptionTest.php index 319067a..99e8998 100644 --- a/repo/tests/phpunit/includes/Api/SetDescriptionTest.php +++ b/repo/tests/phpunit/includes/Api/SetDescriptionTest.php @@ -53,7 +53,7 @@ self::doTestSetTermExceptions( $params, $expected ); } - public function testUserCanEditWhenTheyHaveSufficientPermission() { + public function testUserCanSetDescriptionWhenTheyHaveSufficientPermission() { $userWithAllPermissions = $this->createUserWithGroup( 'all-permission' ); $this->setMwGlobals( 'wgGroupPermissions', [ @@ -72,7 +72,7 @@ $this->assertEquals( 1, $result['success'] ); } - public function testUserCannotSetLabelWhenTheyLackPermission() { + public function testUserCannotSetDescriptionWhenTheyLackPermission() { $userWithInsufficientPermissions = $this->createUserWithGroup( 'no-permission' ); $userWithAllPermissions = $this->createUserWithGroup( 'all-permission' ); -- To view, visit https://gerrit.wikimedia.org/r/365230 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ad64c53875a82980e0c441681f9fca88f04c1ec Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits