Elukey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365595 )

Change subject: profile::piwik::backup: remove duplicate old backup clean cron
......................................................................

profile::piwik::backup: remove duplicate old backup clean cron

The predump script already removes old data (15d old) so this cron
is not needed.

Bug: T164073
Change-Id: I20a8b8fc011fe88be4f505ea6155422b529a29f2
---
M modules/profile/manifests/piwik/backup.pp
1 file changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/365595/1

diff --git a/modules/profile/manifests/piwik/backup.pp 
b/modules/profile/manifests/piwik/backup.pp
index 951b492..52b52ef 100644
--- a/modules/profile/manifests/piwik/backup.pp
+++ b/modules/profile/manifests/piwik/backup.pp
@@ -24,14 +24,8 @@
         content => 
"[client]\nuser=${backup_username}\npassword=\'${backup_password}\'\n",
     }
 
-    cron { 'delete_old_backups':
-        command => "/usr/bin/find /srv/backup -mtime +${retention_days} -exec 
/bin/rm {} \\;",
-        weekday => 0,
-        hour    => 0,
-        minute  => 0,
-        user    => 'root',
-    }
-
+    # Backups older than 15 days will be deleted by the predump script before
+    # the mysqldump, so a cron is not needed.
     backup::mysqlset {'piwik':
         xtrabackup       => false,
         per_db           => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20a8b8fc011fe88be4f505ea6155422b529a29f2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <ltosc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to