Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/365609 )
Change subject: Introduce commit-message-validator for nice commit messages ...................................................................... Introduce commit-message-validator for nice commit messages Add a new tox environment that invokes the MediaWiki commit message validator. Has been in use at least on VisualEditor and helps formatting nice commit message. Ref: https://www.mediawiki.org/wiki/Commit-message-validator https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines Change-Id: Ia032b4f672b1c33c4435be86c16eb9e87cd595d6 --- M tox.ini 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Faidon Liambotis: Looks good to me, approved Alexandros Kosiaris: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/tox.ini b/tox.ini index 14d87a9..67c616e 100644 --- a/tox.ini +++ b/tox.ini @@ -2,7 +2,7 @@ minversion = 1.6 skipsdist = True -envlist = py27, pep8 +envlist = commit-message, py27, pep8 [flake8] max-line-length = 100 @@ -31,6 +31,10 @@ -rmodules/admin/data/requirements.txt commands = nosetests modules/admin/data modules/mediawiki/files/apache/sites/redirects +[testenv:commit-message] +deps = commit-message-validator +commands = commit-message-validator + [testenv:pep8] deps = flake8==3.3.0 commands = flake8 -- To view, visit https://gerrit.wikimedia.org/r/365609 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia032b4f672b1c33c4435be86c16eb9e87cd595d6 Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Alexandros Kosiaris <[email protected]> Gerrit-Reviewer: BryanDavis <[email protected]> Gerrit-Reviewer: Faidon Liambotis <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
