Brion VIBBER has submitted this change and it was merged. Change subject: Rotate escape overlay arrow for RTL languages ......................................................................
Rotate escape overlay arrow for RTL languages Also, delete unused arrow images and pngcrush the one we use. Change-Id: If0358d185331b1954171bbb0b165ea500e44e07f --- M less/common/mf-navigation.less M less/mf-mixins.less M less/modules/mf-tables.less D stylesheets/common/images/arrow-left-2.png D stylesheets/common/images/arrow-left-beta.png M stylesheets/common/images/arrow-left.png M stylesheets/common/mf-navigation.css 7 files changed, 20 insertions(+), 4 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less index a6d2c66..5708b69 100644 --- a/less/common/mf-navigation.less +++ b/less/common/mf-navigation.less @@ -359,13 +359,20 @@ height: @headerHeight; width: @searchBarPaddingLeft; background: none; - background-image: url(images/arrow-left-2.png); + background-image: url(images/arrow-left.png); background-repeat: no-repeat; background-position: center center; text-indent: -999px; .background-size( auto, @searchBoxHeight ); } +html[dir="rtl"] { + a.escapeOverlay, + button.escapeOverlay { + .transform( rotate(180deg) ); + } +} + html.navigationEnabled { body, #mw-mf-viewport, diff --git a/less/mf-mixins.less b/less/mf-mixins.less index 6734388..ed76fcd 100644 --- a/less/mf-mixins.less +++ b/less/mf-mixins.less @@ -76,3 +76,8 @@ background: rgb(@r, @g, @b); background: rgba(@r, @g, @b, @a); } + +.transform( @transform ) { + -webkit-transform: @transform; + transform: @transform; +} diff --git a/less/modules/mf-tables.less b/less/modules/mf-tables.less index 5a99a4e..88fd456 100644 --- a/less/modules/mf-tables.less +++ b/less/modules/mf-tables.less @@ -44,8 +44,7 @@ &.expanded { td { - -webkit-transform: rotate(180deg); - transform: rotate(180deg); + .transform( rotate(180deg) ); } } diff --git a/stylesheets/common/images/arrow-left-2.png b/stylesheets/common/images/arrow-left-2.png deleted file mode 100644 index 27ca9a6..0000000 --- a/stylesheets/common/images/arrow-left-2.png +++ /dev/null Binary files differ diff --git a/stylesheets/common/images/arrow-left-beta.png b/stylesheets/common/images/arrow-left-beta.png deleted file mode 100644 index 2e86989..0000000 --- a/stylesheets/common/images/arrow-left-beta.png +++ /dev/null Binary files differ diff --git a/stylesheets/common/images/arrow-left.png b/stylesheets/common/images/arrow-left.png index 04fccc3..6339228 100644 --- a/stylesheets/common/images/arrow-left.png +++ b/stylesheets/common/images/arrow-left.png Binary files differ diff --git a/stylesheets/common/mf-navigation.css b/stylesheets/common/mf-navigation.css index 7087ff0..ba7a706 100644 --- a/stylesheets/common/mf-navigation.css +++ b/stylesheets/common/mf-navigation.css @@ -436,7 +436,7 @@ height: 46px; width: 40px; background: none; - background-image: url(images/arrow-left-2.png); + background-image: url(images/arrow-left.png); background-repeat: no-repeat; background-position: center center; text-indent: -999px; @@ -447,6 +447,11 @@ -webkit-background-size: auto 30px; background-size: auto 30px; } +html[dir="rtl"] a.escapeOverlay, +html[dir="rtl"] button.escapeOverlay { + -webkit-transform: rotate(180deg); + transform: rotate(180deg); +} html.navigationEnabled body, html.navigationEnabled #mw-mf-viewport, html.navigationEnabled #mw-mf-page-center { -- To view, visit https://gerrit.wikimedia.org/r/53484 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0358d185331b1954171bbb0b165ea500e44e07f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: JGonera <jgon...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits