jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/365711 )
Change subject: Fix failing SkinMinerva unit test
......................................................................
Fix failing SkinMinerva unit test
Bug: T170624
Change-Id: I13fff8eba06abad43291e481f32d9eb30c0f031b
---
M tests/phpunit/skins/SkinMinervaTest.php
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/tests/phpunit/skins/SkinMinervaTest.php
b/tests/phpunit/skins/SkinMinervaTest.php
index 9c47447..54bfd12 100644
--- a/tests/phpunit/skins/SkinMinervaTest.php
+++ b/tests/phpunit/skins/SkinMinervaTest.php
@@ -33,7 +33,7 @@
}
/**
- * @coversDefaultClass SkinMinerva
+ * @coversDefaultClass SkinMinerva
* @group MobileFrontend
*/
class SkinMinervaTest extends MediaWikiTestCase {
@@ -170,12 +170,7 @@
public function testGetContextSpecificModules( $fontchangerValue,
$backToTopValue,
$moduleName, $expected
) {
- $skin = TestingAccessWrapper::newFromObject(
- $this->getMockBuilder( SkinMinerva::class )
- ->disableOriginalConstructor()
- ->setMethods( [ 'getTitle' ] )
- ->getMock()
- );
+ $skin = new SkinMinerva();
$title = Title::newFromText( 'Test' );
$testContext = RequestContext::getMain();
$testContext->setTitle( $title );
--
To view, visit https://gerrit.wikimedia.org/r/365711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13fff8eba06abad43291e481f32d9eb30c0f031b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
