20after4 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365891 )

Change subject: Change $deploy_user home directory to /var/lib/${deploy_user}
......................................................................

Change $deploy_user home directory to /var/lib/${deploy_user}

This probably should not be hard-coded to /var/lib/scap?

Change-Id: I28402371379b2b9f7e9ee05dd89af17d9afae71d
---
M modules/scap/manifests/target.pp
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/91/365891/1

diff --git a/modules/scap/manifests/target.pp b/modules/scap/manifests/target.pp
index 00a9955..38c3052 100644
--- a/modules/scap/manifests/target.pp
+++ b/modules/scap/manifests/target.pp
@@ -72,10 +72,12 @@
             user { $deploy_user:
                 ensure     => present,
                 shell      => '/bin/bash',
-                home       => '/var/lib/scap',
+                home       => "/var/lib/${deploy_user}",
                 system     => true,
                 managehome => true,
             }
+        } else {
+            notice("manage_user is true but user $deploy_user already defined")
         }
         if !defined(Ssh::Userkey[$deploy_user]) {
             $key_name_safe = regsubst($key_name, '\W', '_', 'G')

-- 
To view, visit https://gerrit.wikimedia.org/r/365891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28402371379b2b9f7e9ee05dd89af17d9afae71d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: 20after4 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to