jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/363000 )
Change subject: Remove newline at end of MWExceptionRenderer::getShowBacktraceError ...................................................................... Remove newline at end of MWExceptionRenderer::getShowBacktraceError Also add a period at the end of the sentence. This changes the HTML comment from <!-- Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information --> to <!-- Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information. --> This is a follow-up to 842b7a1769 (T162315). Change-Id: I45ff4f856ad1c0dc72066fce7771077ff4663785 --- M includes/exception/MWExceptionRenderer.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/exception/MWExceptionRenderer.php b/includes/exception/MWExceptionRenderer.php index 579b6ca..60cbf15 100644 --- a/includes/exception/MWExceptionRenderer.php +++ b/includes/exception/MWExceptionRenderer.php @@ -211,7 +211,7 @@ "\nBacktrace:\n" . MWExceptionHandler::getRedactedTraceAsString( $e ) . "\n"; } else { - return self::getShowBacktraceError( $e ); + return self::getShowBacktraceError( $e ) . "\n"; } } @@ -242,7 +242,7 @@ $vars[] = '$wgShowDBErrorBacktrace = true;'; } $vars = implode( ' and ', $vars ); - return "Set $vars at the bottom of LocalSettings.php to show detailed debugging information\n"; + return "Set $vars at the bottom of LocalSettings.php to show detailed debugging information."; } /** -- To view, visit https://gerrit.wikimedia.org/r/363000 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45ff4f856ad1c0dc72066fce7771077ff4663785 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits