Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366765 )

Change subject: Enable Generic.CodeAnalysis.UnconditionalIfStatement.Found and 
Generic.Files.EndFileNewline.NotFound
......................................................................

Enable Generic.CodeAnalysis.UnconditionalIfStatement.Found and 
Generic.Files.EndFileNewline.NotFound

Change-Id: I5feebf0e7e9758ee65221cf243f1133a9246e223
---
M phpcs.xml
M wmf-config/wikitech.php
2 files changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/65/366765/1

diff --git a/phpcs.xml b/phpcs.xml
index 3fdd8a8..1ee13a2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -24,12 +24,6 @@
        <rule ref="Generic.Arrays.DisallowLongArraySyntax.Found">
                <severity>0</severity>
        </rule>
-       <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement.Found">
-               <severity>0</severity>
-       </rule>
-       <rule ref="Generic.Files.EndFileNewline.NotFound">
-               <severity>0</severity>
-       </rule>
        <rule ref="Generic.Files.LineLength.MaxExceeded">
                <exclude-pattern>wmf-config/interwiki.php</exclude-pattern>
        </rule>
diff --git a/wmf-config/wikitech.php b/wmf-config/wikitech.php
index 1956447..084023d 100644
--- a/wmf-config/wikitech.php
+++ b/wmf-config/wikitech.php
@@ -44,7 +44,9 @@
 $wgLDAPDebug = 5; // Maximally verbose logs for Andrew Bogott, 8-Dec-2015
 
 // Local debug logging for troubleshooting LDAP issues
+// @codingStandardsIgnoreStart
 if ( false ) {
+       // @codingStandardsIgnoreEnd
        $wgLDAPDebug = 5;
        $monolog = LoggerFactory::getProvider();
        $monolog->mergeConfig( [

-- 
To view, visit https://gerrit.wikimedia.org/r/366765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5feebf0e7e9758ee65221cf243f1133a9246e223
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to