jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366753 )
Change subject: RCFilters: Exclude 'hidden' filters from
'areCurrentFiltersEmpty' query
......................................................................
RCFilters: Exclude 'hidden' filters from 'areCurrentFiltersEmpty' query
Bug: T171129
Change-Id: I831692efbc5562d0f1d7433b9933118c7a9f6f14
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index 06fa0aa..a30ebbf 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -702,7 +702,7 @@
// Check if there are either any selected items or any items
// that have highlight enabled
return !this.getItems().some( function ( filterItem ) {
- return filterItem.isSelected() ||
filterItem.isHighlighted();
+ return !filterItem.getGroupModel().isHidden() && (
filterItem.isSelected() || filterItem.isHighlighted() );
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/366753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I831692efbc5562d0f1d7433b9933118c7a9f6f14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
