Hoo man has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367031 )
Change subject: dispatchChanges: Release client lock if an Exception occurs
......................................................................
dispatchChanges: Release client lock if an Exception occurs
Holding the lock for "ever" is very bad and can lead to short
hiccups breaking the entire dispatch process for a fair bit.
Writing a proper test for this is probably very hard, thus I
didn't both for now (please note that the rest of the exception
handling code is untested as well, AFAICT).
Change-Id: I12ffff189bcc0421e5b9c855bf4e0c0c7f8ec55b
---
M repo/maintenance/dispatchChanges.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/31/367031/1
diff --git a/repo/maintenance/dispatchChanges.php
b/repo/maintenance/dispatchChanges.php
index c507954..b20a85b 100644
--- a/repo/maintenance/dispatchChanges.php
+++ b/repo/maintenance/dispatchChanges.php
@@ -233,6 +233,9 @@
} else {
$this->log( "ERROR: $ex" );
}
+ if ( $wikiState ) {
+
$dispatcher->getDispatchCoordinator()->releaseClient( $wikiState );
+ }
}
$t = ( microtime( true ) - $startTime );
--
To view, visit https://gerrit.wikimedia.org/r/367031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12ffff189bcc0421e5b9c855bf4e0c0c7f8ec55b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
