Rush has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/367424 )
Change subject: wmcs: Use yaml.safe_load in nova_fullstack_test.py
......................................................................
wmcs: Use yaml.safe_load in nova_fullstack_test.py
Python's yaml module unfortunately defaults to unsafe de-serialization
behavior. The do provide a `safe_load` method however which will not
create arbitrary objects from a YAML content stream.
Change-Id: I7303906045f61da15309c103326c8c05ae5cb02e
---
M modules/openstack/files/nova_fullstack_test.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Rush: Looks good to me, approved
jenkins-bot: Verified
Volans: Looks good to me, but someone else must approve
diff --git a/modules/openstack/files/nova_fullstack_test.py
b/modules/openstack/files/nova_fullstack_test.py
index b11c22c..d368b3d 100644
--- a/modules/openstack/files/nova_fullstack_test.py
+++ b/modules/openstack/files/nova_fullstack_test.py
@@ -186,7 +186,7 @@
logging.debug(out)
try:
- yprun = yaml.load(out)
+ yprun = yaml.safe_load(out)
except:
logging.warning("Yaml conversion failed for Puppet results")
yprun = {}
--
To view, visit https://gerrit.wikimedia.org/r/367424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7303906045f61da15309c103326c8c05ae5cb02e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: Madhuvishy <mviswanat...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
