Rush has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367426 )

Change subject: wmcs: Use yaml.safe_load in shinkengen
......................................................................


wmcs: Use yaml.safe_load in shinkengen

Python's yaml module unfortunately defaults to unsafe de-serialization
behavior. The do provide a `safe_load` method however which will not
create arbitrary objects from a YAML content stream.

Change-Id: Idb522f0c82ab869010adcba8003cd1c0a6964f4f
---
M modules/shinken/files/shinkengen
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Rush: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/shinken/files/shinkengen b/modules/shinken/files/shinkengen
index 3daa45f..51b5e38 100755
--- a/modules/shinken/files/shinkengen
+++ b/modules/shinken/files/shinkengen
@@ -103,7 +103,7 @@
     args = argparser.parse_args()
 
     with open('/etc/shinkengen.yaml') as f:
-        config = yaml.load(f)
+        config = yaml.safe_load(f)
 
     for project in config['projects']:
         instances = get_instances(project, config['observer_pass'])

-- 
To view, visit https://gerrit.wikimedia.org/r/367426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb522f0c82ab869010adcba8003cd1c0a6964f4f
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: Madhuvishy <mviswanat...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to