jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365685 )

Change subject: tests: Use new QUnit 2 module hook names
......................................................................


tests: Use new QUnit 2 module hook names

Replacing QUnit.setup()/QUnit.teardown() with the already-available-
in-qunit-1.x QUnit.beforeEach()/QUnit.afterEach() methods.

Bug: T170873
Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
---
M modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js 
b/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
index 9072a8e..9617e6a 100644
--- a/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
+++ b/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
@@ -8,12 +8,12 @@
 window.MWWIKITEXT_MOCK_API = true;
 
 QUnit.module( 've.ui.MWWikitextStringTransferHandler (Cite)', 
QUnit.newMwEnvironment( {
-       setup: function () {
+       beforeEach: function () {
                // Mock XHR for mw.Api()
                this.server = window.MWWIKITEXT_MOCK_API ? 
this.sandbox.useFakeServer() : null;
                ve.test.utils.mwEnvironment.setup.call( this );
        },
-       teardown: ve.test.utils.mwEnvironment.teardown
+       afterEach: ve.test.utils.mwEnvironment.teardown
 } ) );
 
 /* Tests */

-- 
To view, visit https://gerrit.wikimedia.org/r/365685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to