Rush has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367710 )

Change subject: diamond: set diskspace filesystems explicitly
......................................................................


diamond: set diskspace filesystems explicitly

Newer versions of diamond seem to include nfsv4 instead
of just nfs and that means picking up the NFS shares for
any server that mounts them which is useless for us.

I noticed we are also currently not tracking some non-default filesystems
I believe we want such as fuse.fuse_dfs (hdfs) on stat1003:

    Ignoring /mnt/hdfs since it is of type \
    fuse.fuse_dfs which  is not in the list of filesystems

Bug: T171583
Change-Id: I633ccd19b26f7cd40ec8a2db371fb639a7ce142a
---
M modules/diamond/manifests/init.pp
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Rush: Looks good to me, approved
  jenkins-bot: Verified
  Filippo Giunchedi: Looks good to me, but someone else must approve



diff --git a/modules/diamond/manifests/init.pp 
b/modules/diamond/manifests/init.pp
index 61deb44..dd53594 100644
--- a/modules/diamond/manifests/init.pp
+++ b/modules/diamond/manifests/init.pp
@@ -117,7 +117,12 @@
     }
 
     diamond::collector { 'Network': }
-    diamond::collector { 'DiskSpace': }
+    diamond::collector { 'DiskSpace':
+        settings => {
+            filesystems => 
'ext2,ext3,ext4,xfs,fuse.fuse_dfs,fat32,fat16,btrfs',
+        },
+    }
+
     diamond::collector { 'LoadAverage': }
     diamond::collector { 'Memory': }
     diamond::collector { 'VMStat': }

-- 
To view, visit https://gerrit.wikimedia.org/r/367710
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I633ccd19b26f7cd40ec8a2db371fb639a7ce142a
Gerrit-PatchSet: 10
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to