jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/368442 )
Change subject: Hygiene: Do not use ConfigFactory::getDefaultInstance() ...................................................................... Hygiene: Do not use ConfigFactory::getDefaultInstance() ConfigFactory::getDefaultInstance() is deprecated and code should use MediaWikiServices instead Change-Id: I085c6cfd724e6005bf8ea6933bf13de98dadb018 --- M SkinVector.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/SkinVector.php b/SkinVector.php index b0915aa..16f0950 100644 --- a/SkinVector.php +++ b/SkinVector.php @@ -37,7 +37,8 @@ private $responsiveMode = false; public function __construct() { - $this->vectorConfig = ConfigFactory::getDefaultInstance()->makeConfig( 'vector' ); + $this->vectorConfig = \MediaWiki\MediaWikiServices::getInstance()->getConfigFactory() + ->makeConfig( 'vector' ); } /** @inheritdoc */ -- To view, visit https://gerrit.wikimedia.org/r/368442 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I085c6cfd724e6005bf8ea6933bf13de98dadb018 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Vector Gerrit-Branch: master Gerrit-Owner: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits