Jhernandez has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368460 )
Change subject: WIP: Use EcmaScript modules instead of common.js modules ...................................................................... WIP: Use EcmaScript modules instead of common.js modules Why: Because they are the approved standard by TC39 and Ecma. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941 --- M .eslintrc.json M package.json M resources/dist/index.js M resources/dist/index.js.map M src/actionTypes.js M src/actions.js M src/changeListener.js M src/changeListeners/eventLogging.js M src/changeListeners/footerLink.js M src/changeListeners/index.js M src/changeListeners/linkTitle.js M src/changeListeners/render.js M src/changeListeners/settings.js M src/changeListeners/statsv.js M src/changeListeners/syncUserSettings.js M src/constants.js M src/container.js M src/experiments.js M src/formatter.js M src/gateway/index.js M src/gateway/mediawiki.js M src/gateway/rest.js M src/gateway/restFormatters.js M src/index.js M src/instrumentation/eventLogging.js M src/instrumentation/statsv.js M src/isEnabled.js M src/preview/model.js M src/previewBehavior.js M src/reducers/eventLogging.js M src/reducers/index.js M src/reducers/nextState.js M src/reducers/preview.js M src/reducers/settings.js M src/reducers/statsv.js M src/title.js M src/ui/renderer.js M src/ui/settingsDialog.js M src/userSettings.js M src/wait.js M tests/node-qunit/actions.test.js M tests/node-qunit/changeListener.test.js M tests/node-qunit/changeListeners/eventLogging.test.js M tests/node-qunit/changeListeners/footerLink.test.js M tests/node-qunit/changeListeners/linkTitle.test.js M tests/node-qunit/changeListeners/render.test.js M tests/node-qunit/changeListeners/settings.test.js M tests/node-qunit/changeListeners/statsv.test.js M tests/node-qunit/changeListeners/syncUserSettings.test.js M tests/node-qunit/container.test.js M tests/node-qunit/counts.test.js M tests/node-qunit/experiments.test.js M tests/node-qunit/formatter.test.js M tests/node-qunit/gateway/index.test.js M tests/node-qunit/gateway/mediawiki.test.js M tests/node-qunit/gateway/rest.test.js M tests/node-qunit/instrumentation/eventLogging.test.js M tests/node-qunit/instrumentation/statsv.test.js M tests/node-qunit/integration.test.js M tests/node-qunit/isEnabled.test.js M tests/node-qunit/preview/model.test.js M tests/node-qunit/previewBehavior.test.js M tests/node-qunit/reducers/eventLogging.test.js M tests/node-qunit/reducers/preview.test.js M tests/node-qunit/reducers/settings.test.js M tests/node-qunit/reducers/statsv.test.js A tests/node-qunit/run.js M tests/node-qunit/stubs.js M tests/node-qunit/title.test.js R tests/node-qunit/ui/renderer.test.js M tests/node-qunit/ui/settingsDialog.test.js M tests/node-qunit/userSettings.test.js M tests/node-qunit/wait.test.js 73 files changed, 298 insertions(+), 341 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/60/368460/1 -- To view, visit https://gerrit.wikimedia.org/r/368460 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits