Matěj Suchánek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368552 )
Change subject: Use strict comparison in Special:NewEntity::isListed
......................................................................
Use strict comparison in Special:NewEntity::isListed
Previous bool cast caused 0 (zero) to be interpreted as false.
Bug: T169456
Change-Id: I9581bdd20dd8c1a8f4ea3cca33dad7feac79e918
---
M repo/includes/Specials/SpecialNewEntity.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/52/368552/1
diff --git a/repo/includes/Specials/SpecialNewEntity.php
b/repo/includes/Specials/SpecialNewEntity.php
index 86a193d..ed93d41 100644
--- a/repo/includes/Specials/SpecialNewEntity.php
+++ b/repo/includes/Specials/SpecialNewEntity.php
@@ -75,7 +75,7 @@
* @see SpecialPage::isListed()
*/
public function isListed() {
- return (bool)$this->entityNamespaceLookup->getEntityNamespace(
$this->getEntityType() );
+ return $this->entityNamespaceLookup->getEntityNamespace(
$this->getEntityType() ) !== null;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/368552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9581bdd20dd8c1a8f4ea3cca33dad7feac79e918
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
