EddieGP has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368585 )
Change subject: Show title on the page named '0' ...................................................................... Show title on the page named '0' The string '0' evals to false in the if( $pageTitle ) condition, hence the title was not shown for the page named '0'. Bug: T163084 Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464 --- M includes/skins/SkinMinerva.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue refs/changes/85/368585/1 diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 83af2fc..31cedd0 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -797,7 +797,8 @@ $heading = $this->getUserPageHelper()->getPageUser()->getName(); } else { $pageTitle = $this->getOutput()->getPageTitle(); - if ( $pageTitle ) { + // Loose comparison with '!=' is intentional, to catch null and false too, but not '0' + if ( $pageTitle != '' ) { $heading = $pageTitle; } } -- To view, visit https://gerrit.wikimedia.org/r/368585 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/MinervaNeue Gerrit-Branch: master Gerrit-Owner: EddieGP <wikimedia....@eddie-sh.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits