BryanDavis has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368596 )
Change subject: Do not clobber $out in local scope
......................................................................
Do not clobber $out in local scope
A refactor and a revert combined to make `$out` in the local scope used
for both an object and a string.
Bug: T172077
Change-Id: Ibcab17f82b7454b607329ced112257b43856c15e
(cherry picked from commit c3dc7dd3b5a045ca4cf7d4f1ec4bf0804650d40e)
---
M special/SpecialNovaRole.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager
refs/changes/96/368596/1
diff --git a/special/SpecialNovaRole.php b/special/SpecialNovaRole.php
index 768de0a..8e1a7d0 100644
--- a/special/SpecialNovaRole.php
+++ b/special/SpecialNovaRole.php
@@ -269,13 +269,13 @@
}
}
- $out = '<br />';
+ $outHtml = '<br />';
$returnto = Title::newFromText( $formData['returnto'] );
- $out .= Linker::link(
+ $outHtml .= Linker::link(
$returnto,
$this->msg( 'openstackmanager-backprojectlist'
)->escaped()
);
- $out->addHTML( $out );
+ $out->addHTML( $outHtml );
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/368596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcab17f82b7454b607329ced112257b43856c15e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: wmf/1.30.0-wmf.11
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
