jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366279 )
Change subject: ArticleTarget: set local config to hide welcome dialog
......................................................................
ArticleTarget: set local config to hide welcome dialog
This stops the welcome dialog from being displayed repeatedly if the user
edits the article multiple times in the same pageload.
Bug: T170983
Change-Id: I8cc5990e9acb1ac09a2d6dd95eef8042c70088c7
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 66051ac..af1edd4 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -362,6 +362,7 @@
}
} else {
new mw.Api().saveOption(
'visualeditor-hidebetawelcome', '1' );
+ mw.user.options.set( 'visualeditor-hidebetawelcome',
'1' );
}
this.suppressNormalStartupDialogs = true;
}
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index ffa9d12..9672b02 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -2159,6 +2159,7 @@
if ( prefSaysShow ) {
new mw.Api().saveOption(
'visualeditor-hidebetawelcome', '1' );
+ mw.user.options.set( 'visualeditor-hidebetawelcome',
'1' );
// No need to set a cookie every time for logged-in
users that have already
// set the hidebetawelcome=1 preference, but only if
this isn't a one-off
--
To view, visit https://gerrit.wikimedia.org/r/366279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cc5990e9acb1ac09a2d6dd95eef8042c70088c7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
