Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368942 )
Change subject: QA: Minor tweaks to how we check toast notifications ...................................................................... QA: Minor tweaks to how we check toast notifications A toast autohides within 5 seconds and its display properties are inherited from #mw-notification-area. This slight tweak waits for mw-notification-area to be visible before verifying toast and its contents Change-Id: I89beaf9d131155e958cc9aae84a9e30ffd8e9e4f --- M tests/browser/features/step_definitions/common_article_steps.rb M tests/browser/features/support/pages/article_page.rb 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue refs/changes/42/368942/1 diff --git a/tests/browser/features/step_definitions/common_article_steps.rb b/tests/browser/features/step_definitions/common_article_steps.rb index 0e89e9e..089c896 100644 --- a/tests/browser/features/step_definitions/common_article_steps.rb +++ b/tests/browser/features/step_definitions/common_article_steps.rb @@ -27,7 +27,9 @@ end Then(/^I should see a toast notification$/) do - expect(on(ArticlePage).toast_element.when_present(10)).to be_visible + # To avoid flakey tests check the notification area element first (T170890) + expect(on(ArticlePage)).notification_area_element.when_visible).to be_visible + expect(on(ArticlePage).toast_element.when_visible).to be_visible end Then(/^I should see a toast with message "(.+)"$/) do |msg| diff --git a/tests/browser/features/support/pages/article_page.rb b/tests/browser/features/support/pages/article_page.rb index 064e9a7..2b733ae 100644 --- a/tests/browser/features/support/pages/article_page.rb +++ b/tests/browser/features/support/pages/article_page.rb @@ -144,6 +144,7 @@ div(:spinner_loading, class: 'spinner loading') # toast + div(:notification_area, id: 'mw-notification-area') div(:toast, class: 'mw-notification') # loader -- To view, visit https://gerrit.wikimedia.org/r/368942 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89beaf9d131155e958cc9aae84a9e30ffd8e9e4f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/MinervaNeue Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
