Hello Bartosz Dziewoński, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/368960
to review the following change.
Change subject: Revert "mw.widgets.visibleByteLimit: Temporarily disable whilst
OOjs UI label bug is fixed"
......................................................................
Revert "mw.widgets.visibleByteLimit: Temporarily disable whilst OOjs UI label
bug is fixed"
This reverts commit b6f39380938223a25ee280a96c25ce0d05a4c207.
Not to be merged before the new version of OOjs UI.
Change-Id: Ia194f5835a5d62ad46b498938a4764f0c0964589
---
M
resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/60/368960/1
diff --git
a/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
b/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
index 51b9815..5678a80 100644
---
a/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
+++
b/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
@@ -9,15 +9,12 @@
mediaWiki.widgets.visibleByteLimit = function ( textInputWidget, limit ) {
limit = limit || +textInputWidget.$input.attr( 'maxlength' );
- // Temporarily disabled whilst upstream bug is fixed; T169982
- /*
function updateCount() {
textInputWidget.setLabel( ( limit - $.byteLength(
textInputWidget.getValue() ) ).toString() );
}
textInputWidget.on( 'change', updateCount );
// Initialise value
updateCount();
- */
// Actually enforce limit
textInputWidget.$input.byteLimit( limit );
--
To view, visit https://gerrit.wikimedia.org/r/368960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia194f5835a5d62ad46b498938a4764f0c0964589
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
