Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368968 )
Change subject: build: Bump mediawiki-codesniffer to 0.10.1
......................................................................
build: Bump mediawiki-codesniffer to 0.10.1
Change-Id: I35996e8fa9f35df6247971805d05a6d534a812d8
---
M composer.json
M phpcs.xml
M src/Hooks.php
M src/Person.php
M src/Tree.php
5 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Genealogy
refs/changes/68/368968/1
diff --git a/composer.json b/composer.json
index b920e0e..64ac8b5 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "^0.9",
- "mediawiki/mediawiki-codesniffer": "0.10.0",
+ "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index e1dcde4..74e9072 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,6 +2,4 @@
<ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<file>.</file>
- <exclude-pattern>node_modules</exclude-pattern>
- <exclude-pattern>vendor</exclude-pattern>
</ruleset>
diff --git a/src/Hooks.php b/src/Hooks.php
index 131ee61..267dff2 100644
--- a/src/Hooks.php
+++ b/src/Hooks.php
@@ -13,7 +13,7 @@
/**
* Hooked to ParserFirstCallInit.
* @param Parser &$parser The parser.
- * @return boolean
+ * @return bool
*/
public static function onParserFirstCallInit( Parser &$parser ) {
$parser->setFunctionHook( 'genealogy',
self::class.'::renderParserFunction' );
@@ -150,7 +150,7 @@
* @param Parser $parser The parser object.
* @param string $prop The property name; it will be prefixed with
'genealogy '.
* @param string|Title $val The property value ('full text' will be
used if this is a Title).
- * @param boolean $multi Whether this property can have multiple values
(will be stored as
+ * @param bool $multi Whether this property can have multiple values
(will be stored as
* multiple properties, with an integer appended to their name.
*/
public static function saveProp( Parser $parser, $prop, $val, $multi =
true ) {
diff --git a/src/Person.php b/src/Person.php
index 4764559..76744ad 100644
--- a/src/Person.php
+++ b/src/Person.php
@@ -112,7 +112,7 @@
/**
* Whether or not this person has a birth or death date.
- * @return boolean
+ * @return bool
*/
public function hasDates() {
return $this->getBirthDate() !== false || $this->getDeathDate()
!== false;
@@ -177,7 +177,7 @@
/**
* Get all partners (optionally excluding those that are defined within
the current page).
- * @param boolean $onlyDefinedElsewhere Only return those partners that
are *not* defined
+ * @param bool $onlyDefinedElsewhere Only return those partners that
are *not* defined
* within this Person's page.
* @return Person[] An array of partners, possibly empty. Keyed by the
partner's page DB key.
*/
@@ -229,7 +229,7 @@
/**
* Get the value of a single-valued page property.
* @param string $prop The property.
- * @return string|boolean The property value, or false if not found.
+ * @return string|bool The property value, or false if not found.
*/
public function getPropSingle( $prop ) {
$dbr = wfGetDB( DB_SLAVE );
diff --git a/src/Tree.php b/src/Tree.php
index febf0d9..ef6afc0 100644
--- a/src/Tree.php
+++ b/src/Tree.php
@@ -70,7 +70,7 @@
/**
* Whether any ancestors or descendants have been added to this tree.
- * @return boolean
+ * @return bool
*/
public function hasAncestorsOrDescendants() {
return 0 < ( count( $this->ancestors ) + count(
$this->descendants ) );
--
To view, visit https://gerrit.wikimedia.org/r/368968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35996e8fa9f35df6247971805d05a6d534a812d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Genealogy
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
