[MediaWiki-commits] [Gerrit] Make description an input element - change (mediawiki...MobileFrontend)

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53770


Change subject: Make description an input element
......................................................................

Make description an input element

Encourage single lines rather than multilines

Change-Id: I2ce019aab4053fa017e60f2e36e72f07b44f3e2a
---
M javascripts/modules/mf-photo.js
M less/modules/mf-photo.less
M stylesheets/modules/mf-photo.css
M templates/photoUploadPreview.html
4 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/70/53770/1

diff --git a/javascripts/modules/mf-photo.js b/javascripts/modules/mf-photo.js
index 1c91dbd..ccff974 100644
--- a/javascripts/modules/mf-photo.js
+++ b/javascripts/modules/mf-photo.js
@@ -251,7 +251,7 @@
 
                initialize: function() {
                        var self = this,
-                               $description = this.$( 'textarea' ),
+                               $description = this.$( 'input' ),
                                $submitButton = this.$( 'button.submit' );
                        this.$description = $description;
 
diff --git a/less/modules/mf-photo.less b/less/modules/mf-photo.less
index 648115e..80c1915 100644
--- a/less/modules/mf-photo.less
+++ b/less/modules/mf-photo.less
@@ -57,7 +57,7 @@
                line-height: 150%;
        }
 
-       textarea {
+       input {
                width: 100%;
                height: 6em;
 
diff --git a/stylesheets/modules/mf-photo.css b/stylesheets/modules/mf-photo.css
index 7ffeb7c..2d13b6e 100644
--- a/stylesheets/modules/mf-photo.css
+++ b/stylesheets/modules/mf-photo.css
@@ -48,12 +48,12 @@
   font-size: .75em;
   line-height: 150%;
 }
-.photoPreview textarea {
+.photoPreview input {
   width: 100%;
   height: 6em;
 }
-.photoPreview textarea::-webkit-input-placeholder,
-.photoPreview textarea::-moz-placeholder {
+.photoPreview input::-webkit-input-placeholder,
+.photoPreview input::-moz-placeholder {
   text-align: center;
   line-height: 6em;
 }
diff --git a/templates/photoUploadPreview.html 
b/templates/photoUploadPreview.html
index 9da5a07..60dd34f 100644
--- a/templates/photoUploadPreview.html
+++ b/templates/photoUploadPreview.html
@@ -1,6 +1,6 @@
 <div class="content photoPreview">
        <p class="loading">{{loadingMessage}}</p>
-       <textarea name="description" 
placeholder="{{descriptionPlaceholder}}"></textarea>
+       <input name="description" placeholder="{{descriptionPlaceholder}}">
        <div class="license">{{{license}}}</div>
 </div>
 <div class="buttonBar position-fixed">

-- 
To view, visit https://gerrit.wikimedia.org/r/53770
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ce019aab4053fa017e60f2e36e72f07b44f3e2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits