WMDE-leszek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369402 )

Change subject: Add headers to the fields in the "gloss table"
......................................................................

Add headers to the fields in the "gloss table"

Bug: T172191
Change-Id: I08d19eace64d8a46f6ef388f20ff988217c1c654
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M resources/lexeme.less
M src/View/SensesView.php
5 files changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme 
refs/changes/02/369402/1

diff --git a/extension.json b/extension.json
index 7d96f00..84253d2 100644
--- a/extension.json
+++ b/extension.json
@@ -173,7 +173,9 @@
                                "wikibase-save",
                                "wikibase-cancel",
                                "wikibase-add",
-                               "wikibase-remove"
+                               "wikibase-remove",
+                               "wikibase-gloss-field-language-label",
+                               "wikibase-gloss-field-gloss-label"
                        ]
                },
                "wikibase.lexeme.widgets.LemmaWidget.newLemmaWidgetStore": {
diff --git a/i18n/en.json b/i18n/en.json
index c50f14c..20afaa1 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,6 +18,8 @@
        "wikibase-lexeme-statementsection-statements-about-sense": "Statements 
about $1",
        "wikibase-lexeme-view-senses": "Senses",
        "wikibase-lexeme-gloss-empty": "No gloss defined",
+       "wikibase-gloss-field-language-label": "Language",
+       "wikibase-gloss-field-gloss-label": "Gloss",
        "wikibase-lexeme-summary-wbeditentity-update": "Changed a lexeme",
        "datatypes-type-wikibase-lexeme": "Lexeme",
        "datatypes-type-wikibase-lexeme-form": "Lexeme Form",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 4aa31a7..e203a55 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -23,6 +23,8 @@
        "wikibase-lexeme-statementsection-statements-about-sense": "Heading for 
the list of statements giving specific information about the currently viewed 
Sense of a Lexeme.\n\nParameters:\n* $1 - Sense ID.\n{{Identical|Statements}}",
        "wikibase-lexeme-view-senses": "Subheading for the senses section on a 
lexeme page.\n{{Identical|Sense}}",
        "wikibase-lexeme-gloss-empty": "Placeholder message displayed instead 
of the gloss of the sense in case the gloss in the display language has not 
been specified yet.",
+       "wikibase-gloss-field-language-label": "Label of the field to input the 
language code of the language the gloss of the sense is defined in",
+       "wikibase-gloss-field-gloss-label": "Label of the field to input the 
gloss of the sense",
        "wikibase-lexeme-summary-wbeditentity-update": "Auto-generated edit 
summary when editing a lexeme",
        "datatypes-type-wikibase-lexeme": "The name of a data type for lexemes 
in Wikibase.\n{{Identical|Lexeme}}",
        "datatypes-type-wikibase-lexeme-form": "The name of a data type for 
lexeme forms in Wikibase.",
diff --git a/resources/lexeme.less b/resources/lexeme.less
index 983fc7b..ede8ec2 100644
--- a/resources/lexeme.less
+++ b/resources/lexeme.less
@@ -235,6 +235,10 @@
        border-left: 6px solid #ededed;
 }
 
+.wikibase-lexeme-sense-gloss-table-header {
+       color: #000;
+}
+
 .wikibase-lexeme-sense-glosses-table td {
        vertical-align: top;
 }
diff --git a/src/View/SensesView.php b/src/View/SensesView.php
index b8c14e1..61a49ac 100644
--- a/src/View/SensesView.php
+++ b/src/View/SensesView.php
@@ -177,6 +177,13 @@
                return <<<'HTML'
 <div class="wikibase-lexeme-sense-glosses">
        <table class="wikibase-lexeme-sense-glosses-table">
+               <thead>
+                       <tr class="wikibase-lexeme-sense-gloss-table-header">
+                               <td 
class="wikibase-lexeme-sense-gloss-language">{{'wikibase-gloss-field-language-label'|message}}</td>
+                               
<td>{{'wikibase-gloss-field-gloss-label'|message}}</td>
+                               <td></td>
+                       </tr>
+               </thead>
                <tbody>
                        <tr v-for="gloss in glosses" 
class="wikibase-lexeme-sense-gloss">
                                <td 
class="wikibase-lexeme-sense-gloss-language">

-- 
To view, visit https://gerrit.wikimedia.org/r/369402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08d19eace64d8a46f6ef388f20ff988217c1c654
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to